Skip to content

Conversation

@Warry
Copy link
Contributor

@Warry Warry commented Jul 23, 2013

Added an smooth animation to the button.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!
You have to keep {{ page.release_version }}, because that template is used for all download pages, including the ones for previous releases.

Also I guess you know that, but the <a> is not closed, and has an empty href.

@sjrd
Copy link
Member

sjrd commented Jul 23, 2013

I know that Linux and Mac OS have the same download link. But that's not a reason to show me an Apple download button when I'm on Linux ^^ That will confuse all Linux users.

@sjrd
Copy link
Member

sjrd commented Jul 23, 2013

Otherwise it's nice.

@Warry
Copy link
Contributor Author

Warry commented Jul 23, 2013

It's a bug I have in firefox (doesn't support background-position-x) which is weird.

On Tuesday, July 23, 2013 at 1:46 PM, Sébastien Doeraene wrote:

I know that Linux and Mac OS have the same download link. But that's not a reason to show me an Apple download button when I'm on Linux ^^ That will confuse all Linux users.


Reply to this email directly or view it on GitHub (#69 (comment)).

@sjrd sjrd merged commit 7280e45 into master Jul 26, 2013
@julienrf julienrf deleted the wip-download-page branch February 22, 2017 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants