Skip to content

Conversation

@mbovel
Copy link
Member

@mbovel mbovel commented Nov 27, 2025

i23245a seems flaky, see #23788 (comment). I suggest we disable it temporary to avoid CI failures, until we investigate further.

@odersky
Copy link
Contributor

odersky commented Nov 27, 2025

I had it also failing on my recent PRs.

@hamzaremmal hamzaremmal merged commit 6462d7d into scala:main Nov 27, 2025
83 of 84 checks passed
@som-snytt
Copy link
Contributor

som-snytt commented Nov 27, 2025

If the test fails, it seems to me more likely that the fix needs to be reverted.

Edit: maybe it's not flaky.

https://github.com/scala/scala3/actions/runs/19710004246/job/56472246137

Test 'tests/run/i23245a' failed with output:                                    

Exception: java.lang.NullPointerException thrown from the UncaughtExceptionHandler in thread "main"

Error:  Test dotty.tools.dotc.CompilationTests.runAll failed: java.lang.AssertionError: Run test failed, but should not, reasons:
Error:  encountered 1 test failure(s):
Error:    - generic failure (see test output), took 196.516 sec
Error:      at dotty.tools.vulpix.ParallelTesting$CompilationTest.checkPass(ParallelTesting.scala:1271)
Error:      at dotty.tools.vulpix.ParallelTesting$CompilationTest.checkRuns(ParallelTesting.scala:1235)
Error:      at dotty.tools.dotc.CompilationTests.runAll(CompilationTests.scala:179)
Error:      at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
Error:      at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
Error:      at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Error:      at java.lang.reflect.Method.invoke(Method.java:569)
Error:      ...

@mbovel mbovel deleted the mb/disable-i23245a branch November 27, 2025 16:26
@odersky
Copy link
Contributor

odersky commented Nov 28, 2025

I agree, we should go back to the original issue and find out how we can tweak the fix. @som-snytt can you take a look at this?

@som-snytt
Copy link
Contributor

@odersky yes, I will follow up. I was busy today breaking other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants