Try to fix #24573: Don't treat SAM class with imcompatible Unit result types as a platform SAM #24624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
reviewed
Dec 2, 2025
| // Superaccessors already show up as abstract methods here, so no test necessary | ||
| cls.typeRef.fields.isEmpty && | ||
| // LambdaMetafactory can't handle SAMs with Unit return type unless it's a FunctionN itself | ||
| !cls.typeRef.possibleSamMethods.exists(_.info.resultType.isRef(defn.UnitClass)) |
Member
There was a problem hiding this comment.
No this is not the correct fix. LMF can handle Unit result types all right.
It cannot handle the conflicting requirements of having both Unit and non-Unit, because of a bridge.
Member
Author
|
Still WIP |
noti0na1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #24573, not sure if this is a correct fix.
Try a more strict check for platform SAM