Make Predef capture checked #24643
Merged
Make Predef capture checked #24643
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was forgotten before when we added capture-checked checked stdlib. Maybe it was impossible before due to bootstrap problems? But now it is possible.
hamzaremmal
approved these changes
Dec 3, 2025
Contributor
Author
|
Should this be backported to 3.8.0? Probably better to do the changes to stdlib all in one version. |
Contributor
I'd say yes, from my perspective it looks like a bugfix. I don't see any semantic conflicts in compilation after cherry-picking these 2 commits to the backports queue, haven't executed tests yet |
hamzaremmal
added
the
backport:nominated
WojciechMazur
added
backport:accepted
WojciechMazur
pushed a commit
that referenced
this pull request
Dec 3, 2025
This was forgotten before when we added capture-checked checked stdlib. Maybe it was impossible before due to bootstrap problems? But now it is possible. [Cherry-picked 8067622]
WojciechMazur
pushed a commit
that referenced
this pull request
Dec 3, 2025
This was forgotten before when we added capture-checked checked stdlib. Maybe it was impossible before due to bootstrap problems? But now it is possible. [Cherry-picked 8067622]
WojciechMazur
added a commit
that referenced
this pull request
Dec 3, 2025
Backports #24643 to the 3.8.0-RC3. PR submitted by the release tooling.
WojciechMazur
added
backport:done
WojciechMazur
pushed a commit
that referenced
this pull request
Dec 3, 2025
This was forgotten before when we added capture-checked checked stdlib. Maybe it was impossible before due to bootstrap problems? But now it is possible. [Cherry-picked 8067622]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was forgotten before when we added capture-checked checked stdlib. Maybe it was impossible before due to bootstrap problems? But now it is possible.