Typer#escapingRefs: don't let the types of lower bounds escape #749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0efa171 I changed the definition of
NamedPartsAccumulatorto exclude lower bounds as this is required for the implicit search, butNamedPartsAccumulatoris also used byTyper#escapingRefsso in the following code:the type of
zwas inferred to beFoo[_ >: C]instead ofFoo.To avoid this,
NamedPartsAccumulatorwill only exclude lower bounds if the parameterexcludeLowerBoundsis explicitely set totrue.No test because there is no way to detect that a type has escaped, this might be something that could be added to
TreeChecker.This PR also removes dead code from
Typer#escapingRefs.Review by @odersky .