Skip to content

Add ScalarDB with Kotlin sample #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2024
Merged

Add ScalarDB with Kotlin sample #68

merged 1 commit into from
Jul 31, 2024

Conversation

@brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Jul 30, 2024

Description

This PR adds ScalarDB with Kotlin sample. This is basically copied from https://github.com/scalar-labs/scalardb/tree/master/docs/getting-started-kotlin.

Related issues and/or PRs

N/A

Changes made

  • Added ScalarDB with Kotlin sample.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@brfrn169 brfrn169 self-assigned this Jul 30, 2024
josh-wong
josh-wong approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@josh-wong josh-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As mentioned in https://github.com/scalar-labs/docs-internal-scalardb/pull/246#pullrequestreview-2206877310, I was able to run this sample application locally by following the instructions in the updated doc👍

Thank you!🙇🏻‍♂️

Torch3333
Torch3333 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

komamitsu
komamitsu approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@komamitsu
Copy link
Contributor

komamitsu commented Jul 31, 2024

@brfrn169 Just noticed this build test in CI wasn't copied. Is it okay?

@komamitsu komamitsu mentioned this pull request Jul 31, 2024
Merged
6 tasks
@brfrn169
Copy link
Collaborator Author

brfrn169 commented Jul 31, 2024 •
edited
Loading

@komamitsu

@brfrn169 Just noticed this build test in CI wasn't copied. Is it okay?

Thanks. @KodaiD will do that later.

kota2and3kan
kota2and3kan approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

feeblefakie
feeblefakie approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 3ea4fb9 into main Jul 31, 2024
@feeblefakie feeblefakie deleted the add-scalardb-kotlin-sample branch July 31, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@komamitsu komamitsu komamitsu approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

@Torch3333 Torch3333 Torch3333 approved these changes

@josh-wong josh-wong josh-wong approved these changes

@kota2and3kan kota2and3kan kota2and3kan approved these changes

Assignees

@brfrn169 brfrn169

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@brfrn169 @komamitsu @feeblefakie @Torch3333 @josh-wong @kota2and3kan