Remove docs directory and update README #2127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brfrn169
force-pushed
the
remove-docs-and-update-readme
branch
from
f739d1c to
64ccd80
Compare
brfrn169
requested review from
Torch3333,
feeblefakie,
josh-wong,
komamitsu and
kota2and3kan
josh-wong
requested changes
Jul 30, 2024
Member
josh-wong
left a comment
josh-wong
left a comment
There was a problem hiding this comment.
I've added some comments and suggestions. PTAL!
Co-authored-by: Josh Wong <joshua.wong@scalar-labs.com>
komamitsu
approved these changes
Jul 31, 2024
| - name: Build Getting Started project | ||
| run: ./gradlew assemble | ||
|
|
||
| build-check-example-project-for-kotlin: |
Contributor
There was a problem hiding this comment.
As I commented on scalar-labs/scalardb-samples#68 (comment), this isn't copied to scalardb-samples. Probably it would be great if we add equivalent build tests to scalardb-samples later.
Collaborator
Author
There was a problem hiding this comment.
@komamitsu Yes. We should do that. Thanks.
@KodaiD Let's do that later.
This was referenced Jul 31, 2024
brfrn169
added a commit
that referenced
this pull request
Jul 31, 2024
brfrn169
added a commit
that referenced
this pull request
Jul 31, 2024
brfrn169
added a commit
that referenced
this pull request
Jul 31, 2024
brfrn169
added a commit
that referenced
this pull request
Jul 31, 2024
brfrn169
added a commit
that referenced
this pull request
Jul 31, 2024
brfrn169
added a commit
that referenced
this pull request
Jul 31, 2024
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
docsdirectory and updates README.Related issues and/or PRs
N/A
Changes made
docsdirectory.README.mdChecklist
Additional notes (optional)
After merging this PR, we will stop publishing the GitHub pages.
Release notes
N/A