Add CI for sample Java applications #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodaiD
requested review from
Torch3333,
brfrn169,
feeblefakie,
komamitsu and
kota2and3kan
kota2and3kan
reviewed
Oct 9, 2024
Contributor
kota2and3kan
left a comment
kota2and3kan
left a comment
There was a problem hiding this comment.
Thank you for creating a new CI!
I left minor suggestions.
Please take a look when you have time! 🙇♀️
Co-authored-by: kota2and3kan <47254383+kota2and3kan@users.noreply.github.com>
Co-authored-by: kota2and3kan <47254383+kota2and3kan@users.noreply.github.com>
Co-authored-by: kota2and3kan <47254383+kota2and3kan@users.noreply.github.com>
komamitsu
approved these changes
Oct 10, 2024
| name: CI | ||
|
|
||
| on: | ||
| push: |
Contributor
There was a problem hiding this comment.
[minor] Probably this can be removed with some configurations as well as scalar-labs/scalardb#1620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, our sample Java applications for ScalarDB do not have CI.
These sample applications should be able to be built with all Java versions we support (i.e., 8, 11, 17, and 21), and this should be verified in CI.
So, in this PR, I add a CI that runs
./gradlew buildfor all the sample Java applications.Related issues and/or PRs
In the following PRs we have fixed the sample applications so that they work with all Java versions we support (i.e., 8, 11, 17, and 21):
Changes made
./gradlew buildfor all the sample applications except for the followings:Checklist
Additional notes (optional)
I'll fix the documentation of the sample applications after this PR is merged into the main branch.