Skip to content

Conversation

@brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Apr 4, 2024

Description

To reduce the CI time, we will implement the following measures:

  1. Remove the CI trigger for branch pushes.
  2. Enable "Require branches to be up to date before merging" in GitHub branch protection rules.

After implementing these changes, we need to ensure that a branch for a PR is up to date and run CI for it before merging it (2). As a result, CI does not need to be run after merging into the main branch, support branches, or release branches (1).

This PR does the step 1.

Related issues and/or PRs

N/A

Changes made

  • Removed the CI trigger for branch pushes.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit 96bd758 into master Apr 5, 2024
@brfrn169 brfrn169 deleted the remove-ci-trigger-for-branch-pushes branch April 5, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants