Chart: CPU request for the gateway istio-proxy sidecar - #867
Closed
lorenzo-norcini-scale wants to merge 1 commit into
Closed
Chart: CPU request for the gateway istio-proxy sidecar#867lorenzo-norcini-scale wants to merge 1 commit into
lorenzo-norcini-scale wants to merge 1 commit into
Conversation
The sidecar had memory annotations only. On nodes at full CPU request capacity an unrequested sidecar is starved during bootstrap, its postStart hook hangs, and new gateway pods never become Ready, which turns scale-out into negative capacity. Request 250m by default (configurable, no limit). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by the consolidated incident-hardening PR: see the PR referencing this one. |
Collaborator
Author
|
Superseded by #868. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
sidecar.istio.io/proxyCPU: 250m(values-configurable viagateway.sidecarCPURequest, no CPU limit) to the gateway pod annotations, alongside the existing memory-only annotations.Why
During the 2026-08-13 incident recovery, scale-out landed new gateway pods on nodes at ~99% CPU request capacity. With no CPU request, the sidecars were starved during bootstrap, postStart hooks hung up to 14 minutes, and fewer than half of the new pods ever became Ready, so the scale-out reduced effective capacity instead of adding it. A CPU request gives the sidecar a scheduling guarantee; no limit is set to avoid throttling proxy tail latency.
🤖 Generated with Claude Code
Greptile Summary
Adds a configurable CPU request for the gateway’s Istio proxy sidecar while intentionally leaving its CPU limit unset.
sidecar.istio.io/proxyCPUgateway pod annotation.gateway.sidecarCPURequestwith a default value of250m.Confidence Score: 5/5
The PR appears safe to merge, with no concrete changed-code defects identified.
The new Helm value is safely defaulted when existing overlays omit the gateway mapping, and the resulting annotation uses the established gateway sidecar annotation pattern with a valid CPU quantity.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(chart): add istio-proxy CPU request ..." | Re-trigger Greptile
Context used: