[Chore] Make Linting great again #118

prassanna-ravishankar · 2025-09-25T09:58:21Z

No description provided.

- Auto-fixed 190 linting issues with ruff --fix - Mainly import block sorting (I001) and unused imports (F401)

- CLI handlers and commands now use logger instead of print - Environment variables loading uses debug level logging - Debug utilities use info level for user-visible debug info

- Prefix unused arguments with underscore to indicate intentional non-use - Signal handler frame parameter, method args/kwargs, debug config port

- Add 'from e' to exception raises for proper exception chaining (B904) - Remove return from finally block to prevent exception silencing (B012)

- Replace bare except with Exception (E722) - Fix unused loop variable in notebook by using actual event_message - Replace blind Exception assert with specific exceptions (B017)

- Updated temporal ACP template to use logger instead of print for debug output - This will fix generated files to have proper logging practices

- Deprecated functions, framework callbacks, future extension parameters - Fixed import type checking issue by moving import out of TYPE_CHECKING - Added noqa comments for legitimate unused parameters

- Configure pyproject.toml to ignore print statements in tutorials, tests, and dev tools - Add file-level noqa for temporal workflow interface arguments - Add inline noqa for unused provider parameters and framework callbacks - Disable ARG001/ARG002/ARG005 for test patterns in pyproject.toml

- Fix import sorting issue in debug handlers - Add file-level noqa for remaining test files - Add specific ipynb file patterns to pyproject.toml for notebook linting

- File should remain local only for PR discussion reference

…cp tutorial

…tutorial

…rial

…_header_forwarding

…ecessary isinstance calls

- Suppress reportUnknownMemberType, reportUnknownVariableType, reportUnknownParameterType - Suppress reportUnknownArgumentType, reportMissingParameterType - Reduces typing errors from 1959 to 659 (1300+ errors suppressed)

- Use basic type checking as default (for generated SDK code) - Enable strict type checking only for src/agentex/lib, examples, tests - Reduces errors from 2000 to 406 while maintaining strict checking where needed - No global ignore rules - cleaner approach

- Add null checks for task_state access - Fix safe content extraction patterns - Add null checks for span.output assignments - Addresses reportOptionalMemberAccess errors in tutorials

- Add missing RetryPolicy parameters with reasonable defaults - Fix missing Agent created_at/updated_at timestamps in test fixtures - Add type ignore for intentional test error case - Provide missing temporal_address parameter in test

- Add safe content extraction patterns for TaskMessageContent unions - Replace direct .content access with hasattr/getattr patterns - Addresses str | List[str] | Unknown | object | None type errors

- Add type: ignore[arg-type] for handoffs, model_settings, tools, tool_use_behavior - Add ignores for input_guardrails, output_guardrails parameter types - Addresses Agent generic type vs Temporal specific type incompatibilities

- Fix optional parameter type annotations (str = None -> str | None = None) - Fix temporal client function signatures - Fix workflow parameter optional type annotations - Addresses Expression of type None assignment errors

examples/tutorials/00_sync/000_hello_acp/project/acp.py

examples/tutorials/10_agentic/00_base/040_other_sdks/project/acp.py

pyproject.toml

src/agentex/_utils/_typing.py

smoreinis · 2025-09-30T00:42:27Z

First of all thanks so much for getting this PR out Prass!
I got through like the first half of these - I feel like if we could get imports sorted again the amount of changes here would be even less.
I saw that the examples were actually excluded here so also curious if that means there are any example changes needed here or if it means it's possible for us to get examples to lint e.g. in a follow up PR (the changes do all look sensible though, although I wonder if there's anything better we can do to avoid folks having to use the getattr pattern since that could be annoying).
I will try to finish looking at the rest of the files either this evening or tomorrow. Fingers crossed our testing coverage is good enough that it should let us know if anything breaking were to creep in :)

Resolved conflicts: - deploy_handlers.py: kept logger.info with plugin support from main - temporal_client.py: merged plugin support with client property validation - utils.py: integrated plugin validation from main - worker.py: combined plugin support with existing code - fastacp.py: merged plugin parameter handling - temporal_acp.py: integrated plugin support in create method - fastacp.py types: added plugin validation All files formatted with rye run format

Document that the type ignore comment in _typing.py will be overwritten by Stainless generator. This needs to be addressed either by updating the Stainless config or moving the utility to lib/

src/agentex/lib/cli/debug/debug_config.py

prassanna-ravishankar · 2025-10-01T16:59:50Z

@RoxyFarhad + @smoreinis - fixed a few bugs during tutorial level testing with ./launch_tutorials.sh in examples/.

ec9aeac : Fixed a circular import due to import re-ordering. Fixed this by inline ignores, but exposes a deeper code smell. Out of scope of this PR if you agree.
abec38f There was a legacy bug in the tutorials, fixed that
c842473 temporal agents handled .envs differently, so made a nifty little addition to the launch

Last two are slightly out of scope, but I thought I'd fix it as a part of testing this PR

RoxyFarhad

mainly comments about why we have ignores everywhere

examples/tutorials/10_agentic/10_temporal/010_agent_chat/project/workflow.py

examples/tutorials/10_agentic/10_temporal/050_agent_chat_guardrails/project/workflow.py

src/agentex/lib/adk/_modules/tracing.py

src/agentex/lib/adk/providers/_modules/openai.py

src/agentex/lib/adk/_modules/tasks.py

src/agentex/lib/cli/utils/kubectl_utils.py

src/agentex/lib/core/temporal/workers/worker.py

src/agentex/lib/sdk/fastacp/tests/test_fastacp_factory.py

prassanna-ravishankar added 30 commits September 25, 2025 10:29

Fix import sorting and unused imports

f09e0fc

- Auto-fixed 190 linting issues with ruff --fix - Mainly import block sorting (I001) and unused imports (F401)

Replace print statements with logger in core library files

fea615b

- CLI handlers and commands now use logger instead of print - Environment variables loading uses debug level logging - Debug utilities use info level for user-visible debug info

Fix simple unused arguments with underscore prefix

ad13443

- Prefix unused arguments with underscore to indicate intentional non-use - Signal handler frame parameter, method args/kwargs, debug config port

Fix exception handling issues

1a03a33

- Add 'from e' to exception raises for proper exception chaining (B904) - Remove return from finally block to prevent exception silencing (B012)

Fix remaining linting issues

5110dc8

- Replace bare except with Exception (E722) - Fix unused loop variable in notebook by using actual event_message - Replace blind Exception assert with specific exceptions (B017)

Fix print statements in Jinja template

058c70e

- Updated temporal ACP template to use logger instead of print for debug output - This will fix generated files to have proper logging practices

Add inline ignores for obvious unused argument cases

25ba606

- Deprecated functions, framework callbacks, future extension parameters - Fixed import type checking issue by moving import out of TYPE_CHECKING - Added noqa comments for legitimate unused parameters

Final linting cleanup - fix remaining edge cases

fa874e0

- Fix import sorting issue in debug handlers - Add file-level noqa for remaining test files - Add specific ipynb file patterns to pyproject.toml for notebook linting

Remove LINTING-CALLOUTS.md from git tracking

b0c1b98

- File should remain local only for PR discussion reference

Fix typing: safely extract content from TaskMessageContent in hello_a…

9593eed

…cp tutorial

Fix typing: safely access TaskMessageContent attributes in multiturn …

e6d6f57

…tutorial

Fix typing: safely access TaskMessageContent attributes in streaming …

606fc5e

…tutorial

Fix typing: add null checks and safe access in agentic multiturn tuto…

0b19233

…rial

Fix typing: add null checks and safe access in agentic streaming tuto…

5e74015

…rial

Fix typing: add missing type annotations and fix author value in test…

f2d0b61

…_header_forwarding

Fix typing: add type annotations to test_model_utils.py

0702875

Fix typing: improve return type annotations in secret_handlers.py

6f81860

Fix typing: add type annotation for serializable_tasks list in tasks.py

8648883

Fix typing: improve safe content extraction in tutorials to avoid unn…

53fe8f7

…ecessary isinstance calls

Fix import formatting in tasks.py

2a69d3c

Add pyright ignore rules for common generated SDK code issues

a51e586

- Suppress reportUnknownMemberType, reportUnknownVariableType, reportUnknownParameterType - Suppress reportUnknownArgumentType, reportMissingParameterType - Reduces typing errors from 1959 to 659 (1300+ errors suppressed)

Fix additional typing issues in agentic tutorials

a898520

- Add null checks for task_state access - Fix safe content extraction patterns - Add null checks for span.output assignments - Addresses reportOptionalMemberAccess errors in tutorials

Fix simple typing issues in lib directory

0981979

- Add missing RetryPolicy parameters with reasonable defaults - Fix missing Agent created_at/updated_at timestamps in test fixtures - Add type ignore for intentional test error case - Provide missing temporal_address parameter in test

Fix content type extraction in temporal state machine tutorials

b2614ab

- Add safe content extraction patterns for TaskMessageContent unions - Replace direct .content access with hasattr/getattr patterns - Addresses str | List[str] | Unknown | object | None type errors

Fix simple None assignment typing issues

c20cdb4

- Fix optional parameter type annotations (str = None -> str | None = None) - Fix temporal client function signatures - Fix workflow parameter optional type annotations - Addresses Expression of type None assignment errors

Configure pyright for flexible typing on tests and SDK boundaries

7f9e8be

Fix ACP factory typing and override method annotations

eb03f71

Merge branch 'main' into fix/linting-issues

d0f5003

prassanna-ravishankar requested review from RoxyFarhad, jasonyang101 and smoreinis September 25, 2025 19:57

danielmillerp self-requested a review September 29, 2025 13:54

smoreinis reviewed Sep 30, 2025

View reviewed changes

examples/tutorials/00_sync/000_hello_acp/project/acp.py Show resolved Hide resolved

smoreinis reviewed Sep 30, 2025

View reviewed changes

examples/tutorials/00_sync/000_hello_acp/project/acp.py Show resolved Hide resolved

smoreinis reviewed Sep 30, 2025

View reviewed changes

examples/tutorials/10_agentic/00_base/040_other_sdks/project/acp.py Show resolved Hide resolved

smoreinis reviewed Sep 30, 2025

View reviewed changes

pyproject.toml Show resolved Hide resolved

smoreinis reviewed Sep 30, 2025

View reviewed changes

src/agentex/_utils/_typing.py Show resolved Hide resolved

prassanna-ravishankar added 2 commits September 30, 2025 15:56

Add TODO comment for Stainless generator override issue

f96d492

Document that the type ignore comment in _typing.py will be overwritten by Stainless generator. This needs to be addressed either by updating the Stainless config or moving the utility to lib/

prassanna-ravishankar force-pushed the fix/linting-issues branch from 34680eb to f96d492 Compare September 30, 2025 22:43

restore async for in litellm calls

c698a6a

prassanna-ravishankar force-pushed the fix/linting-issues branch from ec89167 to c698a6a Compare September 30, 2025 23:02

smoreinis reviewed Sep 30, 2025

View reviewed changes

src/agentex/lib/cli/debug/debug_config.py Show resolved Hide resolved

prassanna-ravishankar added 3 commits October 1, 2025 15:26

fix circular import

ec9aeac

fix tutorial bug

abec38f

fix: let launch tutorials pass through root .env

c842473

Merge main and resolve conflict in base_acp_server.py

77e9b5c

prassanna-ravishankar enabled auto-merge (squash) October 1, 2025 17:04

fix: new ddtrace linting

2633ef0

RoxyFarhad reviewed Oct 1, 2025

View reviewed changes

RoxyFarhad approved these changes Oct 1, 2025

View reviewed changes

prassanna-ravishankar removed request for danielmillerp and jasonyang101 October 1, 2025 17:46

prassanna-ravishankar merged commit efce531 into main Oct 1, 2025
10 checks passed

prassanna-ravishankar deleted the fix/linting-issues branch October 1, 2025 17:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Chore] Make Linting great again #118

[Chore] Make Linting great again #118

Uh oh!

prassanna-ravishankar commented Sep 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smoreinis commented Sep 30, 2025 •

edited

Loading

Uh oh!

Uh oh!

prassanna-ravishankar commented Oct 1, 2025

Uh oh!

RoxyFarhad left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Chore] Make Linting great again #118

[Chore] Make Linting great again #118

Uh oh!

Conversation

prassanna-ravishankar commented Sep 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smoreinis commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

prassanna-ravishankar commented Oct 1, 2025

Uh oh!

RoxyFarhad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

smoreinis commented Sep 30, 2025 •

edited

Loading