-
Notifications
You must be signed in to change notification settings - Fork 0
[Chore] Make Linting great again #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
f09e0fc
Fix import sorting and unused imports
prassanna-ravishankar fea615b
Replace print statements with logger in core library files
prassanna-ravishankar ad13443
Fix simple unused arguments with underscore prefix
prassanna-ravishankar 1a03a33
Fix exception handling issues
prassanna-ravishankar 5110dc8
Fix remaining linting issues
prassanna-ravishankar 058c70e
Fix print statements in Jinja template
prassanna-ravishankar 25ba606
Add inline ignores for obvious unused argument cases
prassanna-ravishankar c3924d7
Fix remaining linting issues with comprehensive approach
prassanna-ravishankar fa874e0
Final linting cleanup - fix remaining edge cases
prassanna-ravishankar b0c1b98
Remove LINTING-CALLOUTS.md from git tracking
prassanna-ravishankar 9593eed
Fix typing: safely extract content from TaskMessageContent in hello_a…
prassanna-ravishankar e6d6f57
Fix typing: safely access TaskMessageContent attributes in multiturn …
prassanna-ravishankar 606fc5e
Fix typing: safely access TaskMessageContent attributes in streaming …
prassanna-ravishankar 0b19233
Fix typing: add null checks and safe access in agentic multiturn tuto…
prassanna-ravishankar 5e74015
Fix typing: add null checks and safe access in agentic streaming tuto…
prassanna-ravishankar f2d0b61
Fix typing: add missing type annotations and fix author value in test…
prassanna-ravishankar 0702875
Fix typing: add type annotations to test_model_utils.py
prassanna-ravishankar 6f81860
Fix typing: improve return type annotations in secret_handlers.py
prassanna-ravishankar 8648883
Fix typing: add type annotation for serializable_tasks list in tasks.py
prassanna-ravishankar 53fe8f7
Fix typing: improve safe content extraction in tutorials to avoid unn…
prassanna-ravishankar 2a69d3c
Fix import formatting in tasks.py
prassanna-ravishankar a51e586
Add pyright ignore rules for common generated SDK code issues
prassanna-ravishankar 8f5d4fc
Configure pyright for strict checking only on controlled directories
prassanna-ravishankar a898520
Fix additional typing issues in agentic tutorials
prassanna-ravishankar 0981979
Fix simple typing issues in lib directory
prassanna-ravishankar b2614ab
Fix content type extraction in temporal state machine tutorials
prassanna-ravishankar 923bbfc
Add type ignores for OpenAI Agent parameter mismatches in ADK providers
prassanna-ravishankar c20cdb4
Fix simple None assignment typing issues
prassanna-ravishankar 7f9e8be
Configure pyright for flexible typing on tests and SDK boundaries
prassanna-ravishankar eb03f71
Fix ACP factory typing and override method annotations
prassanna-ravishankar ce8f5ab
Fix CLI handler typing and add tutorial type ignores for readability
prassanna-ravishankar c8b68de
Fix test imports and exclude tutorials from type checking
prassanna-ravishankar 6d6f4a3
Fix test imports with proper relative imports, remove pythonPath
prassanna-ravishankar 1f82b96
Phase 1: Fix external API boundary typing with strategic type ignores
prassanna-ravishankar a5cfae0
intermediate cleanup of stash-friendly files
prassanna-ravishankar 0d89ad7
Clean architectural fixes: LLM adapters, temporal client, and OpenAI …
prassanna-ravishankar bf111af
Clean solutions for core SDK and business logic typing
prassanna-ravishankar 7d1a174
Fix test infrastructure and service architecture issues
prassanna-ravishankar 373e98c
Final clean typing solutions: utilities and service boundaries
prassanna-ravishankar 2999495
COMPLETE: Achieve zero typing errors with final inline ignores
prassanna-ravishankar ba922e3
intermediate cleanup of stash-friendly files
prassanna-ravishankar 8a8f62f
FINAL: Complete typing cleanup with perfect linting
prassanna-ravishankar d0f5003
Merge branch 'main' into fix/linting-issues
prassanna-ravishankar 2fdcc1c
Merge branch 'main' into fix/linting-issues
prassanna-ravishankar f96d492
Add TODO comment for Stainless generator override issue
prassanna-ravishankar c698a6a
restore async for in litellm calls
prassanna-ravishankar ec9aeac
fix circular import
prassanna-ravishankar abec38f
fix tutorial bug
prassanna-ravishankar c842473
fix: let launch tutorials pass through root .env
prassanna-ravishankar 77e9b5c
Merge main and resolve conflict in base_acp_server.py
prassanna-ravishankar 2633ef0
fix: new ddtrace linting
prassanna-ravishankar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
examples/tutorials/10_agentic/00_base/000_hello_acp/project/acp.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.