Add Cucumber tests for multi-destination CRR - #2451
Conversation
SylvainSenechal
left a comment
There was a problem hiding this comment.
For me it's pretty much ok, I left some comment that you can check, I think it's ok if the suggested changes aren't applied but there may be some refactoring possible to make it a bit easier to read
831f001 to
6b088f0
Compare
|
Can rebase on top of 2.16 (since #2378 was merged). Includes CRR changes. |
a81cba1 to
d87c34e
Compare
rebase from my branch, which i also just rebased from 2.16 |
6b088f0 to
0adb292
Compare
SylvainSenechal
left a comment
There was a problem hiding this comment.
Just nit on linter warning single line if and alignement of rules array
9eb5dbe to
057833e
Compare
27a424f to
17f9289
Compare
057833e to
fa707f5
Compare
|
The |
|
Heads-up: the deterministic (not flaky — retries won't help) |
17f9289 to
f79a4eb
Compare
fa707f5 to
2f537ca
Compare
Cover V2 multi-rule replication configs, mixed CRR + cloud destinations, overlap validation, disabled rules, and V1 plus legacy comma-StorageClass backward compatibility. Factor shared replication polling and replica-match helpers out of the existing single-destination steps so both single- and multi-destination scenarios reuse them. Issue: ZENKO-5253
2f537ca to
ae00fdb
Compare
Hello maeldonn,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
|
/approve |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue ZENKO-5253. Goodbye maeldonn. The following options are set: approve |
Cover V2 multi-rule replication configs, mixed CRR + cloud destinations, overlap validation, disabled rules, and V1 plus legacy comma-StorageClass backward compatibility. Factor shared replication polling and replica-match helpers out of the existing single-destination steps so both single- and multi-destination scenarios reuse them.
Issue: ZENKO-5253