Skip to content

Add Cucumber tests for multi-destination CRR - #2451

Merged
bert-e merged 1 commit into
development/2.16from
improvement/ZENKO-5253/multi-crr
Jul 22, 2026
Merged

Add Cucumber tests for multi-destination CRR#2451
bert-e merged 1 commit into
development/2.16from
improvement/ZENKO-5253/multi-crr

Conversation

@maeldonn

Copy link
Copy Markdown
Contributor

Cover V2 multi-rule replication configs, mixed CRR + cloud destinations, overlap validation, disabled rules, and V1 plus legacy comma-StorageClass backward compatibility. Factor shared replication polling and replica-match helpers out of the existing single-destination steps so both single- and multi-destination scenarios reuse them.

Issue: ZENKO-5253

@maeldonn
maeldonn requested a review from SylvainSenechal June 29, 2026 08:56
Comment thread tests/functional/ctst/steps/utils/utils.ts Outdated
Comment thread tests/functional/ctst/steps/replication.ts Outdated
Comment thread tests/functional/ctst/features/replication/replication.feature
Comment thread tests/functional/ctst/features/replication/replication.feature Outdated
Comment thread tests/functional/ctst/steps/replication.ts Outdated
Comment thread tests/functional/ctst/features/replication/replication.feature Outdated
Comment thread tests/functional/ctst/steps/replication.ts Outdated
Comment thread tests/functional/ctst/steps/replication.ts

@SylvainSenechal SylvainSenechal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's pretty much ok, I left some comment that you can check, I think it's ok if the suggested changes aren't applied but there may be some refactoring possible to make it a bit easier to read

@maeldonn
maeldonn force-pushed the improvement/ZENKO-5253/multi-crr branch from 831f001 to 6b088f0 Compare June 30, 2026 14:52
@maeldonn
maeldonn requested review from a team, SylvainSenechal and delthas July 1, 2026 08:00
@maeldonn
maeldonn marked this pull request as ready for review July 1, 2026 08:00
@delthas

delthas commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Can rebase on top of 2.16 (since #2378 was merged). Includes CRR changes.

@SylvainSenechal
SylvainSenechal force-pushed the improvement/ZENKO-5263 branch 2 times, most recently from a81cba1 to d87c34e Compare July 1, 2026 20:51
@SylvainSenechal

Copy link
Copy Markdown
Contributor

Can rebase on top of 2.16 (since #2378 was merged). Includes CRR changes.

rebase from my branch, which i also just rebased from 2.16

@maeldonn
maeldonn force-pushed the improvement/ZENKO-5253/multi-crr branch from 6b088f0 to 0adb292 Compare July 2, 2026 12:28

@SylvainSenechal SylvainSenechal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nit on linter warning single line if and alignement of rules array

@delthas delthas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from comment

Comment thread tests/functional/ctst/features/replication/replication.feature Outdated
@maeldonn
maeldonn force-pushed the improvement/ZENKO-5253/multi-crr branch 2 times, most recently from 9eb5dbe to 057833e Compare July 7, 2026 09:12
@SylvainSenechal
SylvainSenechal force-pushed the improvement/ZENKO-5263 branch 2 times, most recently from 27a424f to 17f9289 Compare July 16, 2026 18:02
@maeldonn
maeldonn force-pushed the improvement/ZENKO-5253/multi-crr branch from 057833e to fa707f5 Compare July 17, 2026 09:06
@delthas

delthas commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

The check-workflows failure on this PR is unrelated to its changes: softprops/action-gh-release v3.0.2 (published 2026-07-13, pulled in automatically via the floating @v3 tag in release.yaml) changed its GitHub API call sequence, which breaks the tests/workflows/release.spec.ts mocks on every PR based on development/2.14+. Tracked in ZENKO-5317, fix in #2464.

@delthas

delthas commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Heads-up: the deterministic (not flaky — retries won't help) end2end-pra "PRA (nominal case)" and Kafka Cleaner CTST failures on this PR are a regression in backbeat >= 9.5.0-preview.2: alert threshold defaults like 10*60 render invalid Go-template annotations, prometheus-operator rejects the rule and aborts the entire Prometheus config sync, so the metrics these tests poll never get scraped. Tracked in BB-824, fix in scality/backbeat#2778 — bumping backbeat to 9.5.0-preview.7 once released will unblock it. (Full analysis: #2461 (comment thread).)

@SylvainSenechal
SylvainSenechal force-pushed the improvement/ZENKO-5263 branch from 17f9289 to f79a4eb Compare July 21, 2026 14:56
@maeldonn
maeldonn force-pushed the improvement/ZENKO-5253/multi-crr branch from fa707f5 to 2f537ca Compare July 21, 2026 15:16
Cover V2 multi-rule replication configs, mixed CRR + cloud
destinations, overlap validation, disabled rules, and V1 plus
legacy comma-StorageClass backward compatibility. Factor shared
replication polling and replica-match helpers out of the existing
single-destination steps so both single- and multi-destination
scenarios reuse them.

Issue: ZENKO-5253
@maeldonn
maeldonn force-pushed the improvement/ZENKO-5253/multi-crr branch from 2f537ca to ae00fdb Compare July 22, 2026 11:11
Base automatically changed from improvement/ZENKO-5263 to development/2.16 July 22, 2026 15:41
@bert-e

bert-e commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Jul 22, 2026
@maeldonn

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@bert-e

bert-e commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.16

The following branches have NOT changed:

  • development/2.10
  • development/2.11
  • development/2.12
  • development/2.13
  • development/2.14
  • development/2.15
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

This pull request did not target the following hotfix branch(es) so they
were left untouched:

  • hotfix/2.13.5

Please check the status of the associated issue ZENKO-5253.

Goodbye maeldonn.

The following options are set: approve

@bert-e
bert-e merged commit ae00fdb into development/2.16 Jul 22, 2026
22 checks passed
@bert-e
bert-e deleted the improvement/ZENKO-5253/multi-crr branch July 22, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants