Skip to content

Fix lifecycle late scan alerts - #2488

Merged
bert-e merged 4 commits into
development/8.6from
bugfix/BB-479
Dec 22, 2023
Merged

Fix lifecycle late scan alerts#2488
bert-e merged 4 commits into
development/8.6from
bugfix/BB-479

Conversation

@francoisferrand

@francoisferrand francoisferrand commented Dec 22, 2023

Copy link
Copy Markdown
Contributor
  • Add label to lifecycle conductor metrics
  • Fix handling of kube_service_created in LifecycleLateScan
  • Use max_over_time for LifecycleLateScan instead of last_over_time
  • Release backbeat 8.6.33

Issue: BB-479

@francoisferrand
Add label to lifecycle conductor metrics
0250352 
Adding a label is needed to prevent automatic creation of a serie with value 0 on startup, in every pod which import LifecycleMetrics.

We thus add the `origin` label, which may also be useful on S3C.

Issue: BB-479
@francoisferrand
Fix handling of kube_service_created in LifecycleLateScan
da20ad0 
That metric is in seconds, like `time()`, and thus does not need to be
divided by 1000 like s3_lifecycle_latest_batch_start_time.

Issue: BB-479
@francoisferrand
Use max_over_time for LifecycleLateScan
581fb1e 
The `s3_lifecycle_latest_batch_start_time` metric sometimes gets reset on shutdown,
which breaks `last_over_time`: use `max_over_time` for now instead, as it should have roughly
the same behavior, possibly with a slighly higher load, but avoids this issue.

Issue: BB-479
@francoisferrand
Release backbeat 8.6.33
c0e1bd9 
Issue: BB-479
@bert-e

bert-e commented Dec 22, 2023

Copy link
Copy Markdown
Contributor

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@codecov

codecov Bot commented Dec 22, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e59d916) 63.13% compared to head (c0e1bd9) 63.12%.

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
extensions/lifecycle/LifecycleMetrics.js 89.47% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Bucket Notification 65.61% <ø> (ø)
Core Library 62.16% <ø> (-0.02%) ⬇️
Ingestion 68.97% <ø> (ø)
Lifecycle 71.99% <100.00%> (ø)
Oplog Populator 73.87% <ø> (ø)
Replication 57.34% <ø> (ø)
Bucket Scanner 85.60% <ø> (ø) 
@@                 Coverage Diff                 @@
##           development/8.6    #2488      +/-   ##
===================================================
- Coverage            63.13%   63.12%   -0.01%     
===================================================
  Files                  191      191              
  Lines                12619    12619              
===================================================
- Hits                  7967     7966       -1     
- Misses                4642     4643       +1     
  Partials                10       10
Flag Coverage Δ
bucket-scanner 85.60% <ø> (ø)
ingestion 12.73% <0.00%> (ø)
lib 7.53% <0.00%> (-0.01%) ⬇️
lifecycle 19.18% <100.00%> (ø)
notification 0.90% <0.00%> (ø)
replication 19.66% <0.00%> (ø)
unit 40.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@scality scality deleted a comment from bert-e Dec 22, 2023
@bert-e

bert-e commented Dec 22, 2023

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@francoisferrand

francoisferrand commented Dec 22, 2023

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Dec 22, 2023

Copy link
Copy Markdown
Contributor

Integration data created

I have created the integration data for the additional destination branches.

  • this pull request will merge bugfix/BB-479 into
    development/8.6
  • w/8.7/bugfix/BB-479 will be merged into development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e

bert-e commented Dec 22, 2023

Copy link
Copy Markdown
Contributor

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.6

  • ✔️ development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e

bert-e commented Dec 22, 2023

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.6

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

Please check the status of the associated issue BB-479.

Goodbye francoisferrand.

@bert-e
bert-e merged commit c0e1bd9 into development/8.6 Dec 22, 2023
@bert-e
bert-e deleted the bugfix/BB-479 branch December 22, 2023 22:56
@delthas delthas mentioned this pull request Aug 7, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathan-gramain jonathan-gramain jonathan-gramain approved these changes
@tmacro tmacro Awaiting requested review from tmacro
+1 more reviewer
@rachedbenmustapha rachedbenmustapha rachedbenmustapha approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@francoisferrand @bert-e @jonathan-gramain @rachedbenmustapha