new setting: "allow_expand" #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new setting is a boolean that defaults to true. It is only relevant when a large image is resized. If true, the expand control is displayed just as before. If false, the expand control is not displayed; the user sees the scaled image but cannot zoom in to the original size. I added this setting as an option to simplify the user interface. Some users confuse the expand control with a close button, then can't easily figure out how to un-expand the image and close.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this setting as an option to simplify the user interface.
Some users confuse the expand control with a close button, then
can't easily figure out how to un-expand the image and close.
The new setting is a boolean that defaults to true.
It is only relevant when a large image is resized.
If true, the expand control is displayed just as before.
If false, the expand control is not displayed; the user
sees the scaled image but cannot zoom in to the original size.