Skip to content

Complete clean_rawdata and FIRFilt parity - #171

Merged
suraj-ranganath merged 2 commits into
feature/eeglab-full-standalone-completionfrom
phase/159-clean-firfilt-completion
Jun 7, 2026
Merged

Complete clean_rawdata and FIRFilt parity#171
suraj-ranganath merged 2 commits into
feature/eeglab-full-standalone-completionfrom
phase/159-clean-firfilt-completion

Conversation

@suraj-ranganath

Copy link
Copy Markdown
Member

Closes #159

Summary

  • Complete Phase 2 final matrix rows for clean_rawdata and FIRFilt, including the documented Riemannian ASR limitation.
  • Add native clean_rawdata vis_artifacts diagnostics and wire pop_clean_rawdata visual display through packaged EEGPrep code.
  • Add FIRFilt helper/order/window/report/boundary/plot modules, pop_* wrappers, Qt callback metadata, help resources, docs, tests, and visual capture cases.

Verification

  • EEGPREP_SKIP_MATLAB=1 uv run pytest tests/test_firfilt_helpers.py tests/test_pop_firfilt.py tests/test_gui_pop_firfilt.py tests/test_gui_pop_clean_rawdata.py tests/test_visual_parity.py tests/test_clean_asr.py tests/test_clean_artifacts.py tests/test_clean_rawdata.py tests/test_utils_asr.py tests/test_sample_data_pop_functions.py tests/test_eeglab_final_parity_matrix.py tests/test_eeglab_parity_matrix.py -q
  • uv run --no-sync python -m tools.eeglab_final_parity_matrix --json
  • uv run --no-sync python -m tools.eeglab_parity_matrix --json
  • uv run --no-sync ruff check .
  • uv run --no-sync ruff format --check .
  • uv run --no-sync ty check
  • EEGPREP_SKIP_MATLAB=1 uv run pytest -m "not slow"
  • ./pre-commit.py
  • ./pre-commit.py --changed-from origin/feature/eeglab-full-standalone-completion

Visual Evidence

  • Captured EEGLAB and EEGPrep screenshots for pop_kaiserbeta_dialog, pop_firwsord_dialog, pop_firpmord_dialog, and pop_xfirws_dialog. Side-by-side images will be attached in a PR comment.

@claude

claude Bot commented Jun 7, 2026

Copy link
Copy Markdown

Claude encountered an error after 1m 22s —— View job


PR Review — Complete clean_rawdata and FIRFilt parity

  • Gather context (CLAUDE.md / AGENTS.md, PR diff)
  • Run parallel review agents (compliance, conventions, correctness, EEGLAB parity)
  • Validate candidate findings
  • Post review

@suraj-ranganath

suraj-ranganath commented Jun 7, 2026

Copy link
Copy Markdown
Member Author

🤖

Attachments

FIRFilt GUI visual parity evidence

pop_kaiserbeta_dialog_side_by_side.png pop_firwsord_dialog_side_by_side.png
pop_kaiserbeta_dialog_side_by_side.png pop_firwsord_dialog_side_by_side.png
pop_firpmord_dialog_side_by_side.png pop_xfirws_dialog_side_by_side.png
pop_firpmord_dialog_side_by_side.png pop_xfirws_dialog_side_by_side.png

@suraj-ranganath

Copy link
Copy Markdown
Member Author

🤖 Refreshed FIRPM order dialog visual evidence after review fixes.

pop_firpmord_dialog_review_fix_side_by_side.png
pop_firpmord_dialog_review_fix_side_by_side.png

@suraj-ranganath
suraj-ranganath merged commit 1aba2bf into feature/eeglab-full-standalone-completion Jun 7, 2026
@suraj-ranganath
suraj-ranganath deleted the phase/159-clean-firfilt-completion branch June 7, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant