Fix mutable default argument and incorrect file loading order - #3
Closed
liincu4n wants to merge 1 commit into
Closed
Fix mutable default argument and incorrect file loading order#3liincu4n wants to merge 1 commit into
liincu4n wants to merge 1 commit into
Conversation
liincu4n
commented
Mar 14, 2025
liincu4n
commented
Contributor
- Moved _cache from get_eeglab function signature to a module-level global variable to prevent unintended state persistence across calls.
- Fixed file loading order in OctaveWrapper: ensured pop_saveset writes data before calling pop_loadset, preventing potential runtime errors.
1) Moved _cache from get_eeglab function signature to a module-level global variable to prevent unintended state persistence across calls. 2) Fixed file loading order in OctaveWrapper: ensured pop_saveset writes data before calling pop_loadset, preventing potential runtime errors.
This was referenced May 27, 2026
This was referenced Jun 8, 2026
Closed
22 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.