Skip to content

EDF testing and MATLAB modification - #7

Merged
chkothe merged 20 commits into
bidsfrom
bids_test_arno
Aug 9, 2025
Merged

EDF testing and MATLAB modification#7
chkothe merged 20 commits into
bidsfrom
bids_test_arno

Conversation

@arnodelorme

Copy link
Copy Markdown
Collaborator

Look at the important changes in the eeglabcompat class:

  • I have made MATLAB and Octave use the same code to avoid inconsistencies (Oct2py object are not fully compatible with EEG datasets defined in Python -- events are struct array instead of array etc...). In the end the percentage of usage will be low so it is not worth it to maintain the Octave interface separately from MATLAB (plus if you look internally into Oct2py the files are resaved anyway).
  • I have added a list of function that return EEG datasets although they do not take one as input
  • I have added a test function to compare EDF files

@chkothe

chkothe commented Aug 9, 2025

Copy link
Copy Markdown
Contributor

I think we're good to go, merging. Agreed that deduplicating Octave/Matlab is a good idea, and that interface code is going to evolve as it's already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants