fix: try to detect licensetexts, or pass silently #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
force-pushed
the
issue_868_jk
branch
from
c88d511 to
d2aa2ba
Compare
jkowalleck
commented
Apr 24, 2025
| # latest spec rev: https://discuss.python.org/t/pep-639-round-3-improving-license-clarity-with-better-package-metadata/53020 # noqa: E501 | ||
| content = None | ||
| for mlpath in _LICENSE_LOCATIONS: | ||
| try: |
Author
There was a problem hiding this comment.
the following 9 lines are the actual fix,
Owner
There was a problem hiding this comment.
Ah, indeed. Did not consider the fact that the UnicodeDecodeException has the original bytes. Yes, that is much simpler and robust.
jkowalleck
commented
Apr 24, 2025
| <name>declared license file: my_licenses/richtext.rtf</name> | ||
| <text content-type="application/rtf" encoding="base64">e1xydGYxXGFuc2lcYW5zaWNwZzEyNTJcZGVmZjBcbm91aWNvbXBhdFxkZWZsYW5nMTAzMXtcZm9udHRibHtcZjBcZm5pbFxmY2hhcnNldDAgQ2FsaWJyaTt9fQp7XCpcZ2VuZXJhdG9yIFJpY2hlZDIwIDEwLjAuMTkwNDF9XHZpZXdraW5kNFx1YzEgClxwYXJkXHNhMjAwXHNsMjc2XHNsbXVsdDFcZjBcZnMyMlxsYW5nNyBSVEYgTGljZW5zZSBGaWxlXHBhcgp9CgA=</text> | ||
| </license> | ||
| <license acknowledgement="declared"> |
Author
There was a problem hiding this comment.
the simpler implementation actually manages to detect the UTF16 files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a much simpler fix, don't you think?