Updated TripView to Display day data when individual trip data for a … - #91
Merged
Conversation
…day is not available for the Chart, also an option to change the view from see previous day or previous week data
Contributor
Author
|
Updated the code to work with the changes made to BetterBlueKit and added Inline daily trip details and true analytics for the day's details, based on information from individual trips. I'm not sure about the UI look; please make the changes. 
|
schmidtwmark
added a commit
that referenced
this pull request
Jul 30, 2026
Follow-ups to the merged period-navigation work: - Weekly vs per-trip mode now keys off the data model — the client's .info capability or all-zero summary durations — instead of checking whether every trip starts at exactly midnight, which a real 12:00 AM trip (or a timezone shift) could flip. - The back chevron stops at the earliest fetched trip instead of paging into empty weeks forever. - Replaced the 467-line commented-out preview block (stale pre-rename API, leftover swipe gesture) with live previews that reuse the real TripDetailRow, including an EU day-summary row with drill-down pills. - TripInfoPillView formatted distances with the user's preferred unit as the SOURCE unit, printing EU km values under a mi label; format from the trip's own units. - Drill-down speed conversion goes through Distance.Units instead of a hardcoded 0.621371 and an abbreviation string compare. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Dual-mode period navigation system to
TripDetailsViewto better handle different regional API data structures.Key Changes
isDailySummaryDatacheck.periodNavigatorViewwith left/right chevrons and a dynamic date label to show the current selected period.DragGestureon the list so users can intuitively swipe left/right to move back and forth in time.Testing
periodOffsetcorrectly.