chore: delete two pieces of dead configuration - #59
Merged
Conversation
gitlab_group carried a GitLab-specific default ("mdd/sharepoint") into
the provider-neutral core, and was parsed, validated, and stored but
never read by any consumer in this repo or the private/reference
wrapper distributions. Delete the field, its default constant, the
parse branch, the three tests asserting only the parse round-trip, and
every doc/config mention of the key.
Fixes #42
Co-Authored-By: lsimons-bot <bot@leosimons.com>
Assisted-by: Claude:claude-sonnet-5
test-corpus pointed at tests/confluence/test_corpus_smoke.py, which does not exist in the working tree or anywhere in git history — it was already dangling in the initial commit. It fails immediately with a pytest usage error and is not in the ci task's depends list, so the break went unnoticed. Confluence corpus coverage is already carried by ir-coverage, ir-roundtrip, and the sharepoint corpus matrix test, each with its own task, so there is nothing to repoint this at. Fixes #48 Co-Authored-By: lsimons-bot <bot@leosimons.com> Assisted-by: Claude:claude-sonnet-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated dead-config removals, one commit each so either can be dropped.
1.
gitlab_grouponMappingEntry(#42)src/mdd/sharepoint/mapping.pycarried a GitLab-specific default —gitlab_group: str = field(default="mdd/sharepoint")— into the provider-neutralcore. Two independent problems: it is a house default for a specific group path
on a specific GitLab instance, sitting in the layer whose mirror seam exists so
that a backend supplies exactly that; and the field was dead — parsed,
validated, defaulted, stored, and never read.
The issue could not determine whether a downstream wrapper read it off
MappingEntry. That has now been checked: neither the private SBP wrapper northe public
lsimons/mdd-wrapperreference wrapper contains any reference togitlab_group. So it is simply dead, and this deletes it — field, constant,parse branch, the config-example lines in
mapping.pyandconfigs/sharepoint-mapping.yaml, the documented key in S10, and the one testthat only asserted the parse round-trip.
Fixes #42
2. The
test-corpusmise task (#48)mise run test-corpushas never worked in this repository. It pointed attests/confluence/test_corpus_smoke.py, which is absent from the working treeand from all of git history — the task was already dangling in the initial
commit.
pytestexits 4 (usage error), so it was a hard task failure, not anempty-but-passing run. It went unnoticed because
test-corpusis not in thecitask'sdependslist.There is no Confluence corpus smoke test anywhere, and the corpus is already
exercised by
mise run ir-coverage,mise run ir-roundtripandtests/sharepoint/test_corpus_matrix.py, each with its own task. So the task isdeleted rather than repointed at a test that already has one — which also
removes a misleading entry from
mise tasks.Fixes #48
Not done here
The issue raises whether a check that every
[tasks.*].runpath exists would beworthwhile, since a dangling task path is silent today. Deliberately out of
scope; worth a follow-up issue.
Co-Authored-By: lsimons-bot bot@leosimons.com