fix(hosted): live-view rendered each assistant reply twice (result frame echo)

[schubydoo]

Problem

In the hosted browser live-view, every assistant reply rendered twice — once as white pre-wrap paragraphs, then again immediately below as a green run-on block with the same text.

Root cause (corrected from the issue)

The issue (#591) attributed the duplicate to --include-partial-messages. Empirically (one assistant turn = system×9, stream_event×6, user×1, assistant×1, rate_limit_event×1, result×1), the streamed stream_event partials are already dropped by _hostedFrameToItems (they fall through to []). The real duplicate is the trailing result frame: frame.result repeats the final assistant text, and it was rendered as a kind:"result" item (text-success, no pre-wrap) — the green run-on block.

Fix

• result branch of _hostedFrameToItems now collapses a successful turn to a · turn complete · marker (no text echo), so the reply renders exactly once.
• Text is preserved only on the error path, where result carries content no assistant frame emits (e.g. Not logged in · Please run /login). Gated on is_error, not subtype (which is "success" even on auth failure).
• Removed the now-unreachable green text-success result renderer from dashboard.html.

Test

No JS test harness in CI, so a static guard on the event→items mapping (matching the existing test_no_xshow_element_carries_important_display_utility precedent) asserts the result branch collapses on success, gates text on is_error, and that the green renderer is gone. Full test_app.py + test_hosted.py + test_app_hosted.py (166 tests) green.

Closes #591

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

Fixes the hosted live-view double-render bug (#591) where every assistant reply appeared twice — once as white pre-wrap paragraphs (from the assistant frame) and again as a green run-on block (from the result frame that echoes the same text). The result branch of _hostedFrameToItems now collapses successful turns to a · turn complete · boundary marker and surfaces error text only when frame.is_error is truthy, removing the only path that produced the kind: "result" item.

• _dashboard_script.html: _hostedFrameToItems result branch split on frame.is_error: error path emits kind: "error" with the error text (or "turn failed" as fallback); success path emits a kind: "marker" — no text echo.
• dashboard.html: Removed the kind === 'result' (text-success) renderer, which is now unreachable. The pre-existing kind === 'error' renderer handles the error path.
• tests/test_app.py: Static source-text guard asserts the four invariants: no kind: "result" emission, is_error gating, marker on success, kind: "error" on error path — consistent with the test_no_xshow_element_carries_important_display_utility precedent for pure-JS logic with no CI harness.

Confidence Score: 5/5

The change is narrow and well-bounded: only the result-frame branch of _hostedFrameToItems is touched, the removed renderer was truly unreachable, and the new marker path cannot drop any user-facing error because is_error is the SDK's canonical flag for that case.

The fix correctly targets the root cause, the is_error gate is empirically grounded and documented in both the comment and the PR description, the deleted renderer was dead code, and the static test covers all four invariants. No remaining gaps were identified.

No files require special attention. All four changed files are consistent and correct.

Important Files Changed

Filename	Overview
src/clauster/templates/_dashboard_script.html	Core fix: _hostedFrameToItems result branch now collapses successful turns to a · turn complete · marker and only surfaces text (as kind: "error") when frame.is_error is truthy, stopping the double-render of assistant replies.
src/clauster/templates/dashboard.html	Removed the now-unreachable kind === 'result' (green text-success) renderer; the pre-existing kind === 'error' renderer correctly handles the error path.
tests/test_app.py	New static guard test extracts the result branch by regex and asserts: no kind: "result" emission, is_error gating, collapse to a marker on success, and kind: "error" on the error path.
.changeset/591-hosted-result-frame-double-render.md	Changeset entry correctly tagged as patch; description accurately summarises the root cause and fix.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[WebSocket event] --> B{event.type}
    B -- frame --> C[_hostedFrameToItems]
    C --> D{frame.type}
    D -- system --> E["kind: marker"]
    D -- result --> F{frame.is_error?}
    F -- true --> G["kind: error"]
    F -- false --> H["kind: marker - turn complete - fix #591"]
    D -- assistant/user --> I[Parse message.content]
    I --> J["kind: msg / tool / toolresult"]

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[WebSocket event] --> B{event.type}
    B -- frame --> C[_hostedFrameToItems]
    C --> D{frame.type}
    D -- system --> E["kind: marker"]
    D -- result --> F{frame.is_error?}
    F -- true --> G["kind: error"]
    F -- false --> H["kind: marker - turn complete - fix #591"]
    D -- assistant/user --> I[Parse message.content]
    I --> J["kind: msg / tool / toolresult"]

Loading

_{Reviews (5): Last reviewed commit: "Merge main into hosted-live-view-renders..." | Re-trigger Greptile}