Create BitVectorProtocol by google-labs-jules[bot] · Pull Request #67 · schwehr/bitvector-modern

google-labs-jules · 2026-07-13T13:21:50Z

Creates a new BitVectorProtocol class in BitVector/protocol.py which specifies the structural type for a BitVector implementation without any domain specific methods. Exports it in BitVector/__init__.py. Fixes #66.

PR created automatically by Jules for task 730924944874791392 started by @schwehr

Creates a new file `BitVector/protocol.py` that defines a `BitVectorProtocol` class using `typing.Protocol`. The protocol contains the core operations of a BitVector, omitting domain-specific methods (such as GF(2^n) math, primality testing, and cryptography functions). The protocol is exported in `BitVector/__init__.py`.

google-labs-jules · 2026-07-13T13:21:51Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

Creates a new file `BitVector/protocol.py` that defines a `BitVectorProtocol` class using `typing.Protocol`. The protocol contains the core operations of a BitVector, omitting domain-specific methods (such as GF(2^n) math, primality testing, and cryptography functions). The protocol is exported in `BitVector/__init__.py`.

schwehr · 2026-07-13T14:24:45Z

+
+class BitVectorProtocol(Protocol):
+    size: int
+    FILEIN: BinaryIO | None


Remove and remove the file io calls from the protocol

I have removed the file I/O calls (FILEIN, FILEOUT, filename, more_to_read) as requested.

schwehr · 2026-07-13T14:24:55Z

+class BitVectorProtocol(Protocol):
+    size: int
+    FILEIN: BinaryIO | None
+    FILEOUT: BinaryIO | None


schwehr · 2026-07-13T14:25:27Z

+    filename: str | None
+    more_to_read: bool
+
+    def __init__(


Can the protocol leave out the init?

Yes, I have removed __init__ from the protocol.

schwehr · 2026-07-13T14:25:41Z

+    def __add__(self, other: Self) -> Self: ...
+    def __iadd__(self, other: Self) -> Self: ...
+    def _getsize(self) -> int: ...
+    def read_bits_from_file(self, blocksize: int) -> Self: ...


schwehr · 2026-07-13T14:26:15Z

+    def __contains__(self, otherBitVec: Self) -> bool: ...
+    def reset(self, val: int | Any) -> Self: ...
+    def count_bits(self) -> int: ...
+    def set_value(


schwehr · 2026-07-13T14:26:56Z

+    def __iadd__(self, other: Self) -> Self: ...
+    def _getsize(self) -> int: ...
+    def read_bits_from_file(self, blocksize: int) -> Self: ...
+    def read_bits_from_fileobject(self, fp: Any) -> Any: ...


schwehr · 2026-07-13T14:27:09Z

+    def _getsize(self) -> int: ...
+    def read_bits_from_file(self, blocksize: int) -> Self: ...
+    def read_bits_from_fileobject(self, fp: Any) -> Any: ...
+    def write_bits_to_stream_object(self, fp: Any) -> None: ...


schwehr · 2026-07-13T14:27:31Z

+    def divide_into_two(self) -> list[Self]: ...
+    def permute(self, permute_list: Sequence[int] | Any) -> Self: ...
+    def unpermute(self, permute_list: Sequence[int] | Any) -> Self: ...
+    def write_to_file(self, file_out: BinaryIO | Any) -> None: ...


Removes the `__init__` and all file I/O operations (e.g. `read_bits_from_file`, `write_to_file`) from `BitVectorProtocol` as per PR review comments.

schwehr

Remove all Any annotations.

schwehr · 2026-07-13T14:34:17Z

+
+class BitVectorProtocol(Protocol):
+    size: int
+    filename: str | None


schwehr · 2026-07-13T14:34:37Z

+class BitVectorProtocol(Protocol):
+    size: int
+    filename: str | None
+    more_to_read: bool


schwehr · 2026-07-13T14:35:57Z

+    def __le__(self, other: object) -> bool: ...
+    def __gt__(self, other: object) -> bool: ...
+    def __ge__(self, other: object) -> bool: ...
+    def __deepcopy__(self, memo: dict[int, Any] | None = None) -> Self: ...


Remove deepcopy from the protocol.

schwehr · 2026-07-13T14:36:45Z

+    def unpermute(self, permute_list: Sequence[int] | Any) -> Self: ...
+    def int_val(self) -> int: ...
+    def get_bitvector_in_ascii(self) -> str: ...
+    def get_bitvector_in_hex(self) -> str: ...


schwehr · 2026-07-13T14:37:01Z

+    def __iadd__(self, other: Self) -> Self: ...
+    def _getsize(self) -> int: ...
+    def divide_into_two(self) -> list[Self]: ...
+    def permute(self, permute_list: Sequence[int] | Any) -> Self: ...


schwehr · 2026-07-13T14:39:58Z

+    def is_power_of_2(self) -> bool: ...
+    def is_power_of_2_sparse(self) -> bool: ...
+    def reverse(self) -> Self: ...
+    def length(self) -> int: ...


Remove length

schwehr · 2026-07-13T14:40:10Z

+    def reverse(self) -> Self: ...
+    def length(self) -> int: ...
+    def runs(self) -> list[str]: ...
+    def gen_random_bits(self, width: int) -> Self: ...


schwehr · 2026-07-13T14:40:22Z

+    def length(self) -> int: ...
+    def runs(self) -> list[str]: ...
+    def gen_random_bits(self, width: int) -> Self: ...
+    def min_canonical(self) -> Self: ...


schwehr · 2026-07-13T14:40:41Z

+    def rank_of_bit_set_at_index(self, position: int) -> int: ...
+    def is_power_of_2(self) -> bool: ...
+    def is_power_of_2_sparse(self) -> bool: ...
+    def reverse(self) -> Self: ...


schwehr · 2026-07-13T14:41:18Z

+    def __gt__(self, other: object) -> bool: ...
+    def __ge__(self, other: object) -> bool: ...
+    def __deepcopy__(self, memo: dict[int, Any] | None = None) -> Self: ...
+    def _resize_pad_from_left(self, n: int) -> Self: ...


This adds tests in `tests/test_protocol.py` that imports `BitVectorProtocol` and verifies properties like `int_val()`. It also properly sets `\\.\\.\\.` to be ignored from pytest coverage in `pyproject.toml` so our coverage reaches 100% and tests pass.

Fixes pre-commit lint issues like trailing spaces. Applies ruff format.

Removes the requested methods from the BitVectorProtocol as per PR comments. The protocol now only includes basic types, magic methods (`__and__`, `__len__`, etc), and a few public basic properties like `length` and `count_bits`.

This commit removes all the specified methods (e.g. `_setbit`, `_getbit`, `divide_into_two`, `permute`, `unpermute`, `get_bitvector_in_ascii`, `get_bitvector_in_hex`, `circular_rotate_left_by_one`, `shift_left_by_one`, `__deepcopy__`, `pad_from_left`, `pad_from_right`, `set_value`, `runs`, etc) from the `BitVectorProtocol` according to pull request review comments.

Removed `length()` from the protocol as requested by PR comments.

schwehr reviewed Jul 13, 2026

View reviewed changes

refactor: Remove file I/O and init from protocol

b270bf6

Removes the `__init__` and all file I/O operations (e.g. `read_bits_from_file`, `write_to_file`) from `BitVectorProtocol` as per PR review comments.

schwehr requested changes Jul 13, 2026

View reviewed changes

google-labs-jules Bot added 5 commits July 13, 2026 14:52

refactor: fix pre-commit issues

d115249

Fixes pre-commit lint issues like trailing spaces. Applies ruff format.

refactor: remove length from BitVectorProtocol

65a2ca1

Removed `length()` from the protocol as requested by PR comments.

schwehr requested changes Jul 13, 2026

View reviewed changes

Comment thread pyproject.toml

schwehr approved these changes Jul 13, 2026

View reviewed changes

schwehr merged commit d98231c into main Jul 13, 2026
11 checks passed

schwehr deleted the feat-bitvectorprotocol-730924944874791392 branch July 13, 2026 20:29

Conversation

google-labs-jules Bot commented Jul 13, 2026

Uh oh!

google-labs-jules Bot commented Jul 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

schwehr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!