fix: resolve hexlist type collision in BitVector constructor#78
Conversation
Rename `hexlist` to `hex_str` in `textstring` and `rawbytes` constructor branches to avoid type collisions with `list`-typed variables, fixing static type checker complaints.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Resolves a type checking error in the BitVector constructor where a string (derived from
binascii.hexlify(rawbytes).decode("ascii")and text strings) was assigned to thehexlistvariable, which is otherwise expected to be a list. The variable was renamed tohex_strin those scopes to clarify the type and appease static type checkers.PR created automatically by Jules for task 15682596059061683324 started by @schwehr