TestUtils: valid calling code locations do not include .jar files #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole point of the getCallingCodeLocation() method in the TestUtils
class is to be able to determine a unique location for a directory
inside the target/ directory of the current Maven project.
Therefore, code locations in .jar files are not appropriate: there is
no associated target/ directory.
Thanks, Jaspar Jenkins, for running the regression tests so faithfully
and pointing out that the imagej-plugins-uploader-{ssh,webdav} projects
require this change to run their integration tests properly.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Contributor
Author
|
@ctrueden I would like to merge this ASAP in order to get the Jenkins jobs for the WebDAV and SSH uploaders passing again... We'll need to bump to 2.26.0 because of the new APIs, right? Do you have other pending changes to include in that release? ... but maybe I should test on the Jenkins server itself whether this change actually fixes the bug ;-) Let me do that first, tomorrow 10am. |
Member
|
👍 Looks good on cursory inspection. Testing on the Jenkins server before merging makes total sense! |
dscho
added a commit
that referenced
this pull request
Jul 9, 2014
TestUtils: valid calling code locations do not include .jar files
Contributor
Author
|
Tested on Jenkins, fixes the problem! |
Contributor
Author
|
Deployed the cascade and Jenkins is happy again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole point of the getCallingCodeLocation() method in the TestUtils
class is to be able to determine a unique location for a directory
inside the target/ directory of the current Maven project.
Therefore, code locations in .jar files are not appropriate: there is
no associated target/ directory.
Thanks, Jaspar Jenkins, for running the regression tests so faithfully
and pointing out that the imagej-plugins-uploader-{ssh,webdav} projects
require this change to run their integration tests properly.
Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de