Fix codecov in tests for array api in pairwise metrics#29036
Merged
betatim merged 1 commit intoscikit-learn:mainfrom May 17, 2024
Merged
Fix codecov in tests for array api in pairwise metrics#29036betatim merged 1 commit intoscikit-learn:mainfrom
betatim merged 1 commit intoscikit-learn:mainfrom
Conversation
ogrisel
approved these changes
May 17, 2024
Member
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
I think it might help catch weird bugs, so let's test this case.
EdAbati
reviewed
May 17, 2024
Comment on lines
+1900
to
+1902
| check_array_api_metric( | ||
| metric, array_namespace, device, dtype_name, a_np=X_np, b_np=Y_np | ||
| ) |
Contributor
There was a problem hiding this comment.
Hi all, just realised that we are not passing the metric_kwargs to the function (also in the function call below). I think it should be:
check_array_api_metric(
metric, array_namespace, device, dtype_name, a_np=X_np, b_np=Y_np, ** metric_kwargs
)should I make another PR?
Contributor
Author
There was a problem hiding this comment.
I apologize for missing this.
Contributor
There was a problem hiding this comment.
I also missed it in the previous PR 😇
See fix here: #29045
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow up of #29014
What does this implement/fix? Explain your changes.
Tried adding the condition which codecov reported as partially checked.
Any other comments?
CC: @ogrisel Do we need to add this or can we ignore?