DEP Deprecate getting binary tree stats - #34242
Merged
Merged
Conversation
jeremiedbb
reviewed
Jun 12, 2026
jeremiedbb
left a comment
jeremiedbb
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. A couple of suggestions. Please also add a changelog entry. lgtm otherwise.
Contributor
Author
|
Thank you, will address the comments next week. |
github-actions
Bot
added
the
CI:Linter failure
Contributor
Author
|
MyPy errors will hopefully be fixed by #34303 |
Contributor
|
The linting should be fixed via #34300 now, try merging with |
github-actions
Bot
removed
the
CI:Linter failure
Contributor
Author
|
Merged forward, it's green now. |
Contributor
Author
|
Anything left to do to get this merged? |
Contributor
Author
|
Fixed conflicts and merged forward again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34232
The reason to remove these is because of performance overhead.