Skip to content

First version for ontology task datasets - #3

Closed
aioaneia wants to merge 1 commit into
mainfrom
benchmark-dataset-cso
Closed

First version for ontology task datasets#3
aioaneia wants to merge 1 commit into
mainfrom
benchmark-dataset-cso

Conversation

@aioaneia

Copy link
Copy Markdown
Collaborator

…alyser and dataset generator

@aioaneia
aioaneia requested a review from HamedBabaei January 13, 2025 10:05
@aioaneia aioaneia self-assigned this Jan 13, 2025
@HamedBabaei

Copy link
Copy Markdown
Member

Thanks @aioaneia, I will do the review today.

@aioaneia

Copy link
Copy Markdown
Collaborator Author

@HamedBabaei, as you think would be best. This version is from Friday after our meeting. It doesn't contain the new changes discussed. I'm planning a new commit later today.

@HamedBabaei

HamedBabaei commented Jan 13, 2025

Copy link
Copy Markdown
Member

@aioaneia, thanks for the commits again. I noticed a few minor issues, that it would be great to take into account in the early steps.

  1. Please initiate the pre-commit. This would ensure code consistency and avoid pushing the larger files to GitHub.
  2. I saw you already made a few larger file commits. Unfortunately, there is a single commit, and it is not possible to revert the larger file commit. One simple solution would be to make a copy of your files in another directory, remove the branch (from github.com), and then try to do the commits again, but this time, before making a commit, add the data/ directory to the GitHub .gitignore file.
  3. I recommend changing the src directory name to OntoLearner (or ontolearner) as well. Later we will use this prefix for importing and working with the library.

I hope this will smooth the workings. Feel free to let me know if you need assistance here. I can take care of the changes right away.

@aioaneia aioaneia closed this Jan 13, 2025
@aioaneia
aioaneia deleted the benchmark-dataset-cso branch January 13, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants