[ENH] Add local det tracking gpu#1320
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (18.51%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1320 +/- ##
==========================================
- Coverage 72.61% 72.52% -0.09%
==========================================
Files 297 297
Lines 25850 25886 +36
Branches 3638 3644 +6
==========================================
+ Hits 18771 18775 +4
- Misses 5549 5580 +31
- Partials 1530 1531 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
CHrlS98
left a comment
There was a problem hiding this comment.
makes sense. a few comments on documentation
CHrlS98
left a comment
There was a problem hiding this comment.
A single comment about the doctring. I'll approve anyway.
Tried locally with the fibercup for det/prob and cpu/gpu. Seems consistent. Mean and median length are close.
Stats for prob:
prob_cpu
Num. of fibers: 2321 / 2321
Min. length: 10.0 mm
Max. length: 157.5 mm
Mean length: 81.2 mm
Median length: 79.5 mm
Std. deviation: 44.4 mm
-----------------------------
prob_gpu
Num. of fibers: 2130 / 2130
Min. length: 10.0 mm
Max. length: 158.5 mm
Mean length: 81.1 mm
Median length: 79.5 mm
Std. deviation: 45.2 mm
-----------------------------
Stats for det:
det_cpu
Num. of fibers: 2433 / 2433
Min. length: 10.0 mm
Max. length: 190.5 mm
Mean length: 101.7 mm
Median length: 117.0 mm
Std. deviation: 43.2 mm
-----------------------------
det_gpu
Num. of fibers: 2400 / 2400
Min. length: 10.0 mm
Max. length: 223.5 mm
Mean length: 103.4 mm
Median length: 117.5 mm
Std. deviation: 42.5 mm
-----------------------------
| * Forward tracking: For GPU tracking, the `--forward_only` flag can be used | ||
| to disable backward tracking. This option isn't available for CPU | ||
| tracking. | ||
| * RNG stream: CPU and GPU use different RNG implementations, so the same |
There was a problem hiding this comment.
we call that a "stream"? Also, the command line argument is only --seed and not --rng_seed so not sure it's clear for the user.
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
remove linebreak at first line
Quick description
Please include a summary of the changes and the related issue(s) or improvement(s).
Please also include relevant motivation and context. List any dependencies that are required for this change if needed.
...
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist