Skip to content

FIX: Bump pybids version#1325

Merged
arnaudbore merged 2 commits intoscilus:masterfrom
levje:bump-pybids
Apr 15, 2026
Merged

FIX: Bump pybids version#1325
arnaudbore merged 2 commits intoscilus:masterfrom
levje:bump-pybids

Conversation

@levje
Copy link
Copy Markdown
Contributor

@levje levje commented Apr 14, 2026

Quick description

PyBids is used for scil_bids_validate. Current dcm2bids writes the "bids:" in the URI of the "IntendedFor" field of the JSON file associated with a fmap. The currently used pybids=0.18.1 doesn't seem to support this feature as an error unknown protocol: bids raises when using the scil_bids_validate script with data converted using the most recent dcm2bids version.

Bumping the pybids version solves this issue since the fix was merged in pybids==0.21.0.

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

image

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.61%. Comparing base (d19c255) to head (3501354).
⚠️ Report is 5 commits behind head on master.

❌ Your project status has failed because the head coverage (72.61%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
- Coverage   72.61%   72.61%   -0.01%     
==========================================
  Files         297      297              
  Lines       25850    25850              
  Branches     3638     3638              
==========================================
- Hits        18772    18771       -1     
+ Misses       5549     5548       -1     
- Partials     1529     1531       +2     
Flag Coverage Δ
smoketests 69.79% <ø> (-0.01%) ⬇️
unittests 14.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Scripts 75.08% <ø> (-0.01%) ⬇️
Library 69.65% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arnaudbore
arnaudbore previously approved these changes Apr 15, 2026
Comment thread pyproject.toml Outdated
@arnaudbore arnaudbore enabled auto-merge April 15, 2026 16:53
@arnaudbore arnaudbore disabled auto-merge April 15, 2026 16:54
@arnaudbore arnaudbore merged commit eab1330 into scilus:master Apr 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants