Skip to content

[BF] Quick fix test ml#1326

Merged
arnaudbore merged 1 commit intoscilus:masterfrom
arnaudbore:fix_ml
Apr 15, 2026
Merged

[BF] Quick fix test ml#1326
arnaudbore merged 1 commit intoscilus:masterfrom
arnaudbore:fix_ml

Conversation

@arnaudbore
Copy link
Copy Markdown
Contributor

Quick description

Please include a summary of the changes and the related issue(s) or improvement(s).
Please also include relevant motivation and context. List any dependencies that are required for this change if needed.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@arnaudbore arnaudbore merged commit 27bd3f1 into scilus:master Apr 15, 2026
3 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.62%. Comparing base (d19c255) to head (fdf3052).
⚠️ Report is 2 commits behind head on master.

❌ Your project status has failed because the head coverage (72.62%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1326   +/-   ##
=======================================
  Coverage   72.61%   72.62%           
=======================================
  Files         297      297           
  Lines       25850    25850           
  Branches     3638     3638           
=======================================
+ Hits        18772    18774    +2     
+ Misses       5549     5547    -2     
  Partials     1529     1529           
Flag Coverage Δ
smoketests 69.80% <ø> (+<0.01%) ⬆️
unittests 14.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Scripts 75.10% <ø> (+0.01%) ⬆️
Library 69.65% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant