Skip to content

[BF] use bundles arg#1328

Merged
arnaudbore merged 1 commit intoscilus:masterfrom
arnaudbore:fix_fodf_bundleparc
Apr 20, 2026
Merged

[BF] use bundles arg#1328
arnaudbore merged 1 commit intoscilus:masterfrom
arnaudbore:fix_fodf_bundleparc

Conversation

@arnaudbore
Copy link
Copy Markdown
Contributor

Quick description

Was running all bundles even tho we use args.bundles

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@arnaudbore arnaudbore requested a review from AntoineTheb April 20, 2026 19:13
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.53%. Comparing base (6f213a6) to head (58a05c2).
⚠️ Report is 2 commits behind head on master.

❌ Your project status has failed because the head coverage (72.53%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1328   +/-   ##
=======================================
  Coverage   72.52%   72.53%           
=======================================
  Files         297      297           
  Lines       25885    25885           
  Branches     3644     3644           
=======================================
+ Hits        18774    18775    +1     
+ Misses       5580     5579    -1     
  Partials     1531     1531           
Flag Coverage Δ
smoketests 69.71% <ø> (+<0.01%) ⬆️
unittests 14.08% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Scripts 75.08% <ø> (+<0.01%) ⬆️
Library 69.48% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arnaudbore arnaudbore merged commit 7de90f3 into scilus:master Apr 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant