Unit tests: gradients.bvec_bval_tools#885
Merged
arnaudbore merged 7 commits intoscilus:masterfrom Feb 14, 2024
Merged
Conversation
6bd0299 to
35a8eb9
Compare
Contributor
|
Build passed ! Good Job 🍻 ! |
|
Hello @EmmaRenauld, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-02-14 15:14:17 UTC |
Contributor
|
Build passed ! Good Job 🍻 ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #885 +/- ##
==========================================
+ Coverage 65.91% 65.95% +0.04%
==========================================
Files 384 384
Lines 21341 21337 -4
Branches 3494 3493 -1
==========================================
+ Hits 14067 14073 +6
+ Misses 5668 5659 -9
+ Partials 1606 1605 -1
|
f9a8157 to
f0bc75a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick description
Unit tests for methods in bvec_val_tools.
(Moved
fsl2mrtrixandmrtrix2fslout of there, toio.gradients, because they load and save data. To avoid having to load data in unit tests)....
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
pytest scilpy/gradients/tests/test_bvec_bval_tools.pyChecklist