[essreduce, esssans] Allow int dtypes for frame_time coords and extend Loki LUT range#668
Merged
Conversation
jl-wynen
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests were failing because the
frame_timecoord of a histogram monitor was inint64ns.We perform a
rebininternally which only handlesfloat64dtypes.After fixing that, the computed wavelength were all NaN for monitor 0 because the table started at Ltotal=10m, but the monitor is around 6.8m.
(note that the test will fail again with NaN because all bin edges are 0 in the loki files.)