Scaling dials#134
Merged
YooSunYoung merged 33 commits intomainfrom Apr 7, 2025
Merged
Conversation
Collaborator
aaronfinke
commented
Mar 28, 2025
aaronfinke
commented
- added pyscale support for DIALS files directly instead of having to output as mtz
- manually inputting tof bins/max probabilities so it doesn't have to run through datasets twice;
- I have "trimmed" the mcstas output to make the nexus files smaller (much smaller, like 70%), but the relevant data is in a different form ( (n,6) array vs (n,3) ) so it tries one form and if it fails, runs the other
Co-authored-by: Simon Heybrock <12912489+SimonHeybrock@users.noreply.github.com>
* Separate metatadata from event data for easy export. * Add raw data metadata retrieval part. * Lauetof export interface. * Raw data metadata as dataclass * Allow arbitrary metadata and export time of flight from the coordinate. * Separate metatadata from event data for easy export. * Add raw data metadata retrieval part. * Satety check in the export function. * Add warning filter. * Apply automatic formatting * Apply automatic formatting * Fix typo * Move functions to more proper module. * Lauetof export interface. * Raw data metadata as dataclass * Allow arbitrary metadata and export time of flight from the coordinate. * Specify unit Co-authored-by: Simon Heybrock <12912489+SimonHeybrock@users.noreply.github.com> * Add docstring to export methods. * Add missing attributes. * Remove comments * Fix typo. * Apply automatic formatting --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Simon Heybrock <12912489+SimonHeybrock@users.noreply.github.com>
* remove all zero lines, not just the first one * Apply automatic formatting * Update src/ess/nmx/mcstas/load.py * Apply automatic formatting --------- Co-authored-by: Aaron Finke <aaron.finke@ess.eu> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Sunyoung Yoo <luysunyoung9@gmail.com>
Co-authored-by: Mridul Seth <mail@mriduls.com>
…#125) * add bitshuffle support, compress binned datasets using bitshuffle/LZ4 * Apply automatic formatting * Add docstring and option. --------- Co-authored-by: Aaron Finke <aaron.finke@ess.eu> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: YooSunyoung <luysunyoung9@gmail.com>
…nput toa_min_max_prob
Closed
Merged
YooSunYoung
reviewed
Apr 7, 2025
Member
There was a problem hiding this comment.
This file has a lot of duplication from mtz_io module but I'll just merge it for now to make the further refactoring easier.
YooSunYoung
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.