Fix new cppcheck warnings - #3742
Merged
Merged
Conversation
SimonHeybrock
approved these changes
Aug 4, 2025
SimonHeybrock
left a comment
SimonHeybrock
left a comment
Member
There was a problem hiding this comment.
Looks good, looking at commits as you suggested.
jl-wynen
force-pushed
the
fix-new-cppcheck
branch
from
August 4, 2025 15:01
b0abbdf to
d641e26
Compare
jl-wynen
enabled auto-merge
August 4, 2025 15:01
jl-wynen
force-pushed
the
fix-new-cppcheck
branch
4 times, most recently
from
August 5, 2025 08:36
6e652d4 to
16f1c76
Compare
jl-wynen
force-pushed
the
fix-new-cppcheck
branch
from
August 5, 2025 08:36
16f1c76 to
79d80b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3740
Consider reviewing commit by commit to understand how error codes and fixes are related.
I did not fix
passedByValue(yet) because it looks like there are a lot of affected functions and I don't know how relevant this is for performance.