Skip to content

Add HttpClient.BaseAddress Documentation - #59

Merged
scottoffen merged 1 commit into
mainfrom
normalize
Jul 13, 2026
Merged

Add HttpClient.BaseAddress Documentation#59
scottoffen merged 1 commit into
mainfrom
normalize

Conversation

@scottoffen

Copy link
Copy Markdown
Owner

Summary

Documented the trailing slash requirement on HttpClient.BaseAddress when combining it with a relative route.

  • Added identical <remarks> blocks to all four UsingRoute overloads (string and Uri, generic and non-generic) explaining that BaseAddress must end with a trailing slash for a relative route to be appended correctly, with a worked example and a note that a leading slash on the route does not fix it.
  • Added identical <remarks> blocks to both UsingBase overloads clarifying that they don't accept or set a route, so the trailing slash requirement doesn't apply to them directly.
  • Added a danger admonition to the HttpRequestBuilder docs page explaining the same behavior, with a link to RFC 3986 section 5.

No behavior changed. This is expected Uri combination behavior per RFC 3986, not a bug in FluentHttpClient, so the fix is documentation rather than code.

Related issue

Closes #58

Type

  • Bug fix
  • Feature
  • Docs
  • Other: ___

Checklist

  • Descriptive title and clear description
  • Tests added/updated (xUnit + Shouldly + Moq if needed)
  • Docs updated (if user-facing behavior changed)
  • No cosmetic/whitespace-only changes
  • Follows the contribution guidelines and C# conventions, with readability as a priority

Notes

No tests added since no behavior changed, this is a documentation-only PR. Not a breaking change.

@scottoffen
scottoffen merged commit 26c7c56 into main Jul 13, 2026
2 checks passed
@scottoffen
scottoffen deleted the normalize branch July 13, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UsingRoute/client builder should normalize BaseAddress to include a trailing slash

1 participant