set up debug_filter.cfg to have default filters that can be turned off #4452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small refactoring of the debug filter, needed as a prerequisite for scp-fs2open#4448.
Goober5000
added
the
enhancement
notimaginative
approved these changes
Jun 28, 2022
Contributor
notimaginative
left a comment
notimaginative
left a comment
There was a problem hiding this comment.
One minor thing that you can address, or not, but otherwise it LGTM.
| Outwnd_no_filter_file = 0; | ||
|
|
||
| while ( fgets(inbuf, NAME_LENGTH+3, fp) ) { | ||
| bool enabled; |
Contributor
There was a problem hiding this comment.
Although I think the continue statement below would take care of it, valgrind might throw a warning about this variable not being initialized. It might be nice to just initialize this to false and not have to worry about it again.
But valgrind should be smart enough to not flag this, so I'll leave it up to you whether or not to make the change.
Contributor
Author
There was a problem hiding this comment.
The if() block below looks "neater" with the variable the way it is, so I prefer it as is. I'll give valgrind the benefit of the doubt, and cross that bridge if we come to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactoring of the debug filter, needed as a prerequisite for #4448.