fix some bugs revealed by ships with long display names #5482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several related fixes: 1. Copy the actual ship name, not the display name, to `killer_parent_name` for two reasons: 1a. Since `killer_parent_name` is used to look up the ship, it must be the actual ship name, not the display name. 1b. Copying the display name can cause a buffer overflow because display names can be longer than 31 characters. 2. The display name functionality is moved to the more appropriate location in `player_generate_death_message()`. 3. Remove `player_get_killer_weapon_name()` which only served as a proxy check for whether the weapon index was used or not. 4. Use `ship_registry_get()` rather than `ship_name_lookup()`. 5. Add comments to clarify the use of `killer_parent_name`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several related fixes:
killer_parent_namefor two reasons:a. Since
killer_parent_nameis used to look up the ship, it must be the actual ship name, not the display name.b. Copying the display name can cause a buffer overflow because display names can be longer than 31 characters.
player_generate_death_message().player_get_killer_weapon_name()which only served as a proxy check for whether the weapon index was used or not.ship_registry_get()rather thanship_name_lookup().killer_parent_name.Fixes a bug reported in Discord.