feat(vinted): seller_country filter for cross-border listings (0.14.0)#2
Merged
Merged
Conversation
Adds an optional seller_country kwarg (CSV ISO-2) to vinted.search that filters results to sellers physically located in the given countries (Vinted federates cross-border EU listings; no native country filter). Adds seller_country_code to the item model and seller_country to the search response. Adds 1 credit per uncached seller looked up. Bumps version 0.13.1 -> 0.14.0 (pyproject + SDK_VERSION User-Agent). __init__.__version__ intentionally not touched here to avoid conflict with concurrent in-flight Shopee work in the same file.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to scrapebadger#274. Adds an optional
seller_countrykwarg (CSV ISO-2, e.g.frorfr,be) tovinted.search: Vinted federates cross-border EU listings into each market domain and has no native country filter, so this filters to sellers physically in the given countries. Addsseller_country_codeto the item model andseller_countryto the search response. Billing: +1 credit per uncached seller looked up.Version 0.13.1 → 0.14.0 (pyproject + SDK_VERSION).
Notes for the reviewer/merger:
__init__.py,client.py,README.md,CHANGELOG.md). This PR deliberately excludes it;__init__.__version__is therefore left at 0.13.1 here — reconcile when merging alongside the Shopee branch.Implementation tests reported green (546 passed).