-
Notifications
You must be signed in to change notification settings - Fork 51
Allow to override decimal separator #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kmike
merged 16 commits into
scrapinghub:master
from
WinterComes:customize_decimal_separator_extraction
Oct 18, 2019
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
375d4d8
Add decimal_separator_hint
WinterComes ce88a13
Add decimal_separator_hint to customize number extraction
WinterComes 35f8926
Update description parse_number
WinterComes 0c9b458
Add some tests for decimal_separator_hint
WinterComes 70c0d83
Add more tests.
WinterComes 7bf7846
Rename decimal_separator_hint to decimal_separator
WinterComes ebdaf6d
Add description of decimal_separator in README
WinterComes aac4d78
Refactor choosing decimal_separartor
WinterComes 9a53703
Change regex for text which contains € symbol
WinterComes 16b3839
Merge branch 'master' of github.com:scrapinghub/price-parser into cus…
WinterComes 5f48e4a
Fix extracting price regular expression
WinterComes 74dce76
Add tests for new extract_price_text regexp
WinterComes b72431d
Remove redundant XFAIL
WinterComes 695455e
Update price_parser/parser.py
WinterComes abb2a8d
Update readme
WinterComes 22a2cb3
Update price_parser/parser.py
WinterComes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.