Skip to content

Conversation

@paulkaplan
Copy link
Contributor

@paulkaplan paulkaplan commented Jun 18, 2018

Resolves

What Github issue does this resolve (please include link)?

Resolves #1983
Resolves #2395

Proposed Changes

Describe what this Pull Request does

Allows target pane to handle "drop" events from the costume/sound tiles, which duplicates the costume/sound to that sprite.

dragging-assets

Of note:

  • You can share assets to the sprite that already owns that asset ("yourself"). This duplicates the asset. This is an existing behavior of scratch 2...
  • This does not work on touch yet because of the reliance of hoveredTarget on mouseEnter/mouseLeave events, same issue impacting sharing blocks. I'm working on a fix.
  • In order to prevent reorders from happening when sharing assets, I confined the reorder logic in sortableHOC to only work when you are over the sortable areas container. This might make reordering feel weird, but I can't think of another way to prevent them both from happening. Let's keep an eye on this in feedback/testing /cc @carljbowman.

Copy link
Contributor

@kchadha kchadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kchadha kchadha assigned paulkaplan and unassigned kchadha Jun 19, 2018
@paulkaplan paulkaplan merged commit 677dfa0 into scratchfoundation:develop Jun 19, 2018
@paulkaplan paulkaplan deleted the sharing branch June 19, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dragging costumes/sounds around is laggy after back/forward gestures detected Sharing assets between sprites

2 participants