Skip to content

chore(build): replace binary-loader with arraybuffer-loader #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rschamp merged 1 commit into from
May 8, 2018
Merged

chore(build): replace binary-loader with arraybuffer-loader #35

rschamp merged 1 commit into from
May 8, 2018

Conversation

@mzgoddard
Copy link
Contributor

@mzgoddard mzgoddard commented May 7, 2018

Proposed Changes

  • Replace binary-loader with arraybuffer-loader
  • Remove unused json-loader

Reason for Changes

Sibling of scratchfoundation/scratch-vm#1111

@mzgoddard mzgoddard requested review from cwillisf and rschamp May 7, 2018 17:41
gnarf
gnarf approved these changes May 7, 2018
View reviewed changes
Copy link

@gnarf gnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rschamp rschamp added this to the May 2018 milestone May 8, 2018
@rschamp rschamp merged commit 000dad7 into scratchfoundation:develop May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwillisf cwillisf Awaiting requested review from cwillisf

2 more reviewers

@gnarf gnarf gnarf approved these changes

@rschamp rschamp rschamp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rschamp rschamp

@cwillisf cwillisf

Labels

pr - good to merge

Projects

None yet

Milestone

May 2018

Development

Successfully merging this pull request may close these issues.

4 participants

@mzgoddard @gnarf @rschamp @cwillisf