Skip to content

Conversation

@mzgoddard
Copy link
Contributor

@mzgoddard mzgoddard commented May 3, 2018

Resolves

Pull out the arraybuffer-loader part of #1104.

Proposed Changes

Replace buffer-loader with arraybuffer-loader.

Reason for Changes

buffer-loader inlines binary files in webpack builds by encoding them as numeric literals. Each byte encoded this way uses 2 to 4 bytes. arraybuffer-loader encodes the data as base64 and decodes it back into numbers at runtime using 1.33 bytes for each encoded bytes. arraybuffer-loader saves on bandwidth to download the resulting js and the amount of space in memory the script takes.

Quoted from #1104

Test Coverage

Builds and runs the existing music extension tests.

Copy link
Contributor

@rschamp rschamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants