Fix sprite upload from vector image uploading at the wrong size #1830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se costume assets can get flattened (e.g. while uploading a sprite from file).
rschamp
approved these changes
Dec 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves scratchfoundation/scratch-gui#3608.
Proposed Changes
Fix a bug in load-costume where sprites from vector file upload were not getting loaded correctly because of a failed
===comparison between two object references. Compare asset typeruntimeFormat(which is a string) instead of AssetType object references because costume assets can get flattened (e.g. while uploading a sprite from an image file).This was a regression introduced by #1691 and the corresponding scratchfoundation/scratch-gui#3491 and not caught by #1719.
Test Coverage
Manually tested with svg images.