fix: initialize stack frame params for all procedures #1839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzgoddard
force-pushed
the
fix-missing-no-param
branch
from
f6f9637 to
c812fce
Compare
Contributor
Author
|
A previous change fixed compatibility with Scratch 2 removing 3's unintentional scope leaking. This furthers that change so that procedures with no parameters will also not accidentally use values in other procedure stacks.
mzgoddard
force-pushed
the
fix-missing-no-param
branch
from
c812fce to
20ff75b
Compare
Contributor
Author
|
kchadha
reviewed
Dec 13, 2018
Contributor
kchadha
left a comment
kchadha
left a comment
There was a problem hiding this comment.
LG but requesting documentation =]
Co-Authored-By: mzgoddard <mzgoddard@gmail.com>
Contributor
|
Including this screen shot in here as a good test case:
This comes from the project mentioned in #1729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Related to #1729
Proposed Changes
Initialize parameters before pushing parameters onto a procedure's stack frame. This way all procedure stack frames define params. (Not all stack frames are for procedures. Some are for branching blocks like if or forever.)
Reason for Changes
A previous change fixed compatibility with Scratch 2, removing 3's unintentional scope leaking. This furthers that change so that procedures with no parameters will also not accidentally use values in other procedure stacks.
Test Coverage
Add an additional execute integration test following the existing
procedures-nested-missing-number-param.sb2test.