Skip to content

Fix Linux E2E entitlement state leak - #5157

Merged
louis030195 merged 1 commit into
mainfrom
codex/fix-linux-e2e-entitlement-state
Jul 13, 2026
Merged

Fix Linux E2E entitlement state leak#5157
louis030195 merged 1 commit into
mainfrom
codex/fix-linux-e2e-entitlement-state

Conversation

@louis030195

Copy link
Copy Markdown
Collaborator

What failed

Current main failed Linux E2E twice in zz-app-entitlement-gate.spec.ts. The preceding Basic billing spec seeded an entitled fake user but only restored network mocks; because the skipped stale-subscription suite does not run its cleanup hooks, the entitlement suite inherited that user. Its paywall assertions failed, restarted the app repeatedly, and six trailing specs then lost their WebDriver session.

Fix

  • sign out and clear the native cloud token after the Basic billing spec
  • defensively clear account state before the entitlement-gate suite
  • keep product behavior unchanged; this is E2E isolation only

Validation

  • bun run typecheck
  • git diff --check
  • local native UI attempt was inconclusive because the reused debug binary lacked the WebDriver feature; GitHub Linux E2E is the authoritative clean run

Failing main runs: 29275627355 and 29275728109.

@github-actions github-actions Bot added the potential-ai-slop no before/after video in pr — may be ai slop and closed label Jul 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 thanks for the pr!

i couldn't find a before/after screen recording in the description. prs without a video showing the change in action are hard to review and may be closed soon as potential ai slop.

to clear this:

  • add a short screen recording of the app/cli before and after your change to the pr description
  • drag the file into the description box — github hosts it (never commit media into the repo)
  • the potential-ai-slop label drops automatically once a video is detected

if a video genuinely doesn't apply (docs / ci / pure refactor), reply here and a maintainer can remove the label.

@louis030195
louis030195 marked this pull request as ready for review July 13, 2026 22:20
@louis030195
louis030195 merged commit 5a0279c into main Jul 13, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

potential-ai-slop no before/after video in pr — may be ai slop and closed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant