[codex] keep Live View time selector consistent across macOS - #5456
Merged
Conversation
Contributor
|
👋 thanks for the pr! i couldn't find a before/after screen recording in the description. prs without a video showing the change in action are hard to review and may be closed soon as potential ai slop. to clear this:
if a video genuinely doesn't apply (docs / ci / pure refactor), reply here and a maintainer can remove the label. |
louis030195
marked this pull request as ready for review
July 26, 2026 15:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
Last 7 dayswhy
The time range used a raw
<select>. Tauri renders that control through the system WKWebView, so macOS 15 and macOS 26 supplied different native appearances. On macOS 26 the refreshed system control conflicted with Screenpipe's sharp-cornered interface.The shared selector renders the trigger and popup inside the app, giving the same Screenpipe styling on every supported macOS version.
impact
The Live View time selector now looks and behaves consistently across macOS versions. Time-range persistence and the exact bounds sent to connected Pipes are unchanged.
visual
checks
bunx vitest run --config vitest.config.ts components/settings/__tests__/brain-overview.test.tsx— 38 passedbun run typecheckgit diff --check