Skip to content

[codex] keep Live View time selector consistent across macOS - #5456

Merged
louis030195 merged 1 commit into
mainfrom
codex/fix-live-view-time-select
Jul 26, 2026
Merged

[codex] keep Live View time selector consistent across macOS#5456
louis030195 merged 1 commit into
mainfrom
codex/fix-live-view-time-select

Conversation

@louis030195

Copy link
Copy Markdown
Collaborator

what changed

  • replace the Live View time range's native HTML selector with Screenpipe's shared Radix selector
  • preserve the existing value, disabled state, selectable period policy, responsive sizing, and Pipe refresh behavior
  • update the Live View test to exercise the custom menu and select Last 7 days

why

The time range used a raw <select>. Tauri renders that control through the system WKWebView, so macOS 15 and macOS 26 supplied different native appearances. On macOS 26 the refreshed system control conflicted with Screenpipe's sharp-cornered interface.

The shared selector renders the trigger and popup inside the app, giving the same Screenpipe styling on every supported macOS version.

impact

The Live View time selector now looks and behaves consistently across macOS versions. Time-range persistence and the exact bounds sent to connected Pipes are unchanged.

visual

before

macOS 15       [ Today            ▾ ]
macOS 26        ( Today          ⌄ )   system-rendered

after

macOS 15       [ Today            ˅ ]
macOS 26       [ Today            ˅ ]   Screenpipe-rendered

checks

  • bunx vitest run --config vitest.config.ts components/settings/__tests__/brain-overview.test.tsx — 38 passed
  • bun run typecheck
  • git diff --check

@github-actions github-actions Bot added the potential-ai-slop no before/after video in pr — may be ai slop and closed label Jul 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 thanks for the pr!

i couldn't find a before/after screen recording in the description. prs without a video showing the change in action are hard to review and may be closed soon as potential ai slop.

to clear this:

  • add a short screen recording of the app/cli before and after your change to the pr description
  • drag the file into the description box — github hosts it (never commit media into the repo)
  • the potential-ai-slop label drops automatically once a video is detected

if a video genuinely doesn't apply (docs / ci / pure refactor), reply here and a maintainer can remove the label.

@louis030195
louis030195 marked this pull request as ready for review July 26, 2026 15:54
@louis030195
louis030195 merged commit 20f7fe6 into main Jul 26, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

potential-ai-slop no before/after video in pr — may be ai slop and closed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant