Integration testing cleanup #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes `test-integration` script Removes integration from `test` script Add installation instructions for `screeps-server-mockup` in docs
Contributor
|
Should we remove the files under Right now they don't even compile without the |
Contributor
|
Looks ready to merge to me :) @brisberg I think the test files can stay, since you won't be running them without following the steps in the docs... |
Contributor
|
Alternatively, what would you think of just making the screeps-server-mockup dependency required for this package? Too much? 🔢 |
djD-REK
reviewed
May 1, 2020
djD-REK
reviewed
May 1, 2020
Adds direct example for installing screeps-server-mockup Adds test-integration script that prints where to find more info Fixes typo in integration: testing docs
Member
Author
|
@djD-REK Thanks for bringing this up again. I stalled when considering how much further it could go and forgot that the basic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to keep the framework for integration testing but not require screeps-server-mockup by default. Instead, to instruct users how to install the dependency themselves.
screeps-server-mockupand adding test scriptstest-integrationscripttestscript