feat(558): To use GitLocalize, use Jekyll instead of mkdocs. Add Japanese pages.#88
Conversation
|
Actually, it looks that mkdocs search hits more results than |
|
Seems like a good plan. Can you update the PR so that it includes the most recent guide changes? |
|
Sorry about all the guide changes! 🙇♀️ |
91f9816 to
f296b2d
Compare
|
I included the most recent guide changes. |
|
Can you also update the README with instructions for how to run the guide locally? |
|
This PR is re-adding files that were deleted, and shouldn't be in use by the current theme. Can you make sure that |
|
I updated the README and screenshots, and deleted files that are not actually used in the current theme. |
|
I do think that the lack of any context in the search results, as @tkyi mentioned, is going to be a big problem. Is that something that can be tweaked? I'm also having a lot of issues getting jekyll to work per the directions in the readme. I eventually got it to work by running You may also want to document how you get to alternate language versions of the docs. |
365d0fa to
8154c63
Compare
| cp -R ../../_site/* . | ||
| sd-step exec git 'git add -A' | ||
| sd-step exec git 'git commit -m "Deployed by Screwdriver"' | ||
| sd-step exec git 'git push origin gh-pages' |
There was a problem hiding this comment.
Ah, this probably won't work without source ./ci/git-ssh.sh.
Inside the git-ssh script, it will use the GIT_KEY to setup ssh for you so that you can push
There was a problem hiding this comment.
I added source ./ci/git-ssh.sh command in the deploy.sh.




Context
In Issue screwdriver-cd/screwdriver#558, we try to use GitLocalize instead of Locki. GitLocalize makes localized .md files in the repository. But MkDocs which is used in the screwdriver-cd guide does not support multi languages. Therefore, I experimented with using Jekyll instead of Mkdocs.
Objective
In this PR, I make the docs.screwdriver.cd page using Jekyll, and add Japanese localized pages.


To use Jekyll, I add front matter in exiting pages.
Jekyll does not have the built-in search feature, so that I use the
jekyll-lunr-js-searchJekyll plugin.We can see English pages and Japanese pages.
And we also can search. (The

jekyll-lunr-js-searchdoes not support Japanese, so we can search in English only. )To use GitLocalize, we have to register the screwdriver-cd/guide repository in GitLocalize after this PR is merged.
References
Original issue: screwdriver-cd/screwdriver#558
Jekyll: http://jekyllrb.com/
jekyll-lunr-js-search: https://github.com/slashdotdash/jekyll-lunr-js-search
GitLocalize: https://gitlocalize.com/